linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] clocksource: armada-370-xp: Add missing clock enable
Date: Wed, 22 Oct 2014 16:37:47 +0200	[thread overview]
Message-ID: <5447C13B.6030608@free-electrons.com> (raw)
In-Reply-To: <1413984884-20273-2-git-send-email-ezequiel.garcia@free-electrons.com>

Hi Ezequiel,

On 22/10/2014 15:34, Ezequiel Garcia wrote:
> This commit makes sure the timer clock is prepared and enabled
> before retrieving its rate.

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>


Thanks,

Gregory

> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>  drivers/clocksource/time-armada-370-xp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> index 0451e62..d8555f9 100644
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -293,6 +293,7 @@ static void __init armada_xp_timer_init(struct device_node *np)
>  
>  	/* The 25Mhz fixed clock is mandatory, and must always be available */
>  	BUG_ON(IS_ERR(clk));
> +	clk_prepare_enable(clk);
>  	timer_clk = clk_get_rate(clk);
>  
>  	armada_370_xp_timer_common_init(np);
> @@ -305,6 +306,7 @@ static void __init armada_370_timer_init(struct device_node *np)
>  	struct clk *clk = of_clk_get(np, 0);
>  
>  	BUG_ON(IS_ERR(clk));
> +	clk_prepare_enable(clk);
>  	timer_clk = clk_get_rate(clk) / TIMER_DIVIDER;
>  	timer25Mhz = false;
>  
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2014-10-22 14:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 13:34 [PATCH 0/4] Make Armada 375 use the reference clock when possible Ezequiel Garcia
2014-10-22 13:34 ` [PATCH 1/4] clocksource: armada-370-xp: Add missing clock enable Ezequiel Garcia
2014-10-22 13:50   ` Thomas Petazzoni
2014-10-22 14:37   ` Gregory CLEMENT [this message]
2014-10-22 13:34 ` [PATCH 2/4] watchdog: orion: Use the reference clock on Armada 375 SoC Ezequiel Garcia
2014-10-22 13:51   ` Thomas Petazzoni
2014-10-22 14:02   ` Andrew Lunn
2014-10-22 22:41     ` Ezequiel Garcia
2014-10-22 22:54       ` Guenter Roeck
2014-10-22 23:59       ` Andrew Lunn
2014-10-23  0:55         ` Ezequiel Garcia
2014-10-22 13:34 ` [PATCH 3/4] clocksource: armada-370-xp: Use the reference clock on A375 SoC Ezequiel Garcia
2014-10-22 13:54   ` Thomas Petazzoni
2014-10-22 15:22     ` Ezequiel Garcia
2014-10-22 13:34 ` [PATCH 4/4] ARM: dts: Enable the reference clock for timer and watchdog on Armada 375 SoC Ezequiel Garcia
2014-10-22 13:55   ` Thomas Petazzoni
2014-10-22 15:27     ` Ezequiel Garcia
2014-10-22 13:55 ` [PATCH 0/4] Make Armada 375 use the reference clock when possible Andrew Lunn
2014-10-22 13:56 ` Thomas Petazzoni
2014-10-22 14:08   ` Andrew Lunn
2014-10-22 14:25     ` Thomas Petazzoni
2014-10-22 15:29       ` Ezequiel Garcia
2014-10-23 12:36     ` Ezequiel Garcia
2014-10-23 12:16   ` Ezequiel Garcia
2014-10-23 12:26     ` Thomas Petazzoni
2014-10-23 12:43       ` Ezequiel Garcia
2014-11-03 21:29         ` Thomas Petazzoni
2014-10-22 14:43 ` Gregory CLEMENT
2014-10-22 14:49   ` Thomas Petazzoni
2014-10-22 15:10     ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5447C13B.6030608@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).