From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] irqchip: armada-370-xp: Introduce a is_percpu_irq() helper for readability
Date: Wed, 22 Oct 2014 12:14:26 -0300 [thread overview]
Message-ID: <5447C9D2.1090206@free-electrons.com> (raw)
In-Reply-To: <20141022135813.GK22642@leverpostej>
On 10/22/2014 10:58 AM, Mark Rutland wrote:
> Hi,
>
> On Wed, Oct 22, 2014 at 02:43:43PM +0100, Ezequiel Garcia wrote:
>> This commit introduces a helper function is_percpu_irq(), to be used
>> when interrupts are mapped to decide which ones are set as per CPU.
>>
>> This change will allow to extend the list of per cpu interrupts in a less
>> intrusive fashion; also, it makes the code slightly more readable by keeping
>> a list of the per CPU interrupts.
>
> I believe you can use the existing (and similarly named) irq_is_percpu
> for this.
No, that won't work. The irq_is_percup will work only after you set the
interrupt as per CPU, which is precisely the purpose of
armada_370_xp_mpic_irq_map.
At some point, you need to decide tell the kernel which interrupts are
per CPU, so we put that choice in an internal helper.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-22 15:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 13:43 [PATCH 0/7] Armada 375/38x perf support, and a bonus irqchip driver simplification Ezequiel Garcia
2014-10-22 13:43 ` [PATCH 1/7] irqchip: armada-370-xp: Simplify interrupt map, mask and unmask Ezequiel Garcia
2014-10-31 16:36 ` Gregory CLEMENT
2014-11-04 15:11 ` Ezequiel Garcia
2014-11-10 17:09 ` Gregory CLEMENT
2014-10-22 13:43 ` [PATCH 2/7] irqchip: armada-370-xp: Initialize per cpu registers when CONFIG_SMP=N Ezequiel Garcia
2014-11-12 10:30 ` Gregory CLEMENT
2014-10-22 13:43 ` [PATCH 3/7] irqchip: armada-370-xp: Introduce a is_percpu_irq() helper for readability Ezequiel Garcia
2014-10-22 13:58 ` Mark Rutland
2014-10-22 15:14 ` Ezequiel Garcia [this message]
2014-10-22 13:43 ` [PATCH 4/7] irqchip: armada-370-xp: Enable Performance Counter interrupts Ezequiel Garcia
2014-10-22 13:43 ` [PATCH 5/7] ARM: mvebu: Enable Performance Monitor Unit on Armada 375 SoC Ezequiel Garcia
2014-10-22 14:04 ` Mark Rutland
2014-10-22 22:16 ` Ezequiel Garcia
2014-10-23 9:14 ` Thomas Petazzoni
2014-10-23 11:51 ` Ezequiel Garcia
2014-10-23 12:07 ` Thomas Petazzoni
2014-10-23 12:19 ` Ezequiel Garcia
2014-10-23 13:18 ` Mark Rutland
2014-10-31 16:23 ` Ezequiel Garcia
2014-10-23 9:41 ` Mark Rutland
2014-10-22 13:43 ` [PATCH 6/7] ARM: mvebu: Enable Performance Monitor Unit on Armada 380/385 SoC Ezequiel Garcia
2014-10-22 14:06 ` Mark Rutland
2014-10-22 22:18 ` Ezequiel Garcia
2014-10-22 13:43 ` [PATCH 7/7] ARM: mvebu: Enable perf support in mvebu_v7_defconfig Ezequiel Garcia
2014-10-22 14:11 ` Mark Rutland
2014-10-22 15:33 ` Ezequiel Garcia
2014-10-22 15:38 ` Mark Rutland
2014-11-09 5:23 ` [PATCH 0/7] Armada 375/38x perf support, and a bonus irqchip driver simplification Jason Cooper
2014-11-09 9:41 ` Thomas Petazzoni
2014-11-09 12:18 ` Ezequiel Garcia
2014-11-09 22:50 ` Jason Cooper
2014-11-23 0:45 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447C9D2.1090206@free-electrons.com \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).