From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Fri, 24 Oct 2014 22:36:19 +0900 Subject: [PATCH 2/5] clk: samsung: exynos4415: Add clocks using common clock framework In-Reply-To: References: <1413775749-17539-1-git-send-email-cw00.choi@samsung.com> <1413775935-17743-2-git-send-email-cw00.choi@samsung.com> Message-ID: <544A55D3.8000809@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Daniel, On 10/24/2014 10:18 PM, Daniel Drake wrote: > On Sun, Oct 19, 2014 at 9:32 PM, Chanwoo Choi wrote: >> This patch adds the new clock driver of Exynos4415 SoC based on Cortex-A9 >> using common clock framework. The CMU (Clock Management Unit) of Exynos4415 >> controls PLLs(Phase Locked Loops) and generates system clocks for CPU, buses >> and function clocks for individual IPs. > > There seems to be a lot in common here with other exynos4 variants in > clk-exynos4.c. Have you considered just adding support for the 4415 in > the existing driver? Yes, It is difficult and to make existing clk-exynos4.c more complicated. Exynos4415 has fewer difference from existing clk-exynos4.c and different parent source of mux. For exmaple about PLL, There are different PLLs between Exynos4412 and Exynos4415. - Exynos4412 has APLL, MPLL, EPLL, VPLL. - Exynos4415 has APLL, EPLL, G3D_PLL, ISP_PLL, DISP_PLL and MPLL. Also, MPLL of Exynos4415 was included in CMU_DMC scope. Best Regards, Chanwoo Choi