From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bcm2835: add VideoCore Mailbox to the device tree
Date: Sat, 25 Oct 2014 20:52:52 -0600 [thread overview]
Message-ID: <544C6204.50607@wwwdotorg.org> (raw)
In-Reply-To: <20141024155321.GF10395@x1>
On 10/24/2014 09:53 AM, Lee Jones wrote:
> On Fri, 24 Oct 2014, Lubomir Rintel wrote:
>
>> Follows the generic Mailbox Controller bindings as documented in
>> Documentation/devicetree/bindings/mailbox/mailbox.txt.
>>
>> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>> Cc: Stephen Warren <swarren@wwwdotorg.org>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: devicetree at vger.kernel.org
>> Cc: linux-rpi-kernel at lists.infradead.org
>> Cc: linux-arm-kernel at lists.infradead.org
>> ---
>> arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> index 3342cb1..bd046a9 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -50,6 +50,13 @@
>> #interrupt-cells = <2>;
>> };
>>
>> + mailbox: mailbox at 0x7e00b880 {
>
> Remove the 0x.
>
>> + compatible = "brcm,bcm2835-mbox";
>> + reg = <0x7e00b880 0x40>;
>> + interrupts = <0 1>;
>
> 2 interrupts one cell right? No flags?
The DT binding says 1 IRQ in the list, and the interrupt controller in
bcm2835.dtsi has 2 cells per IRQ.
Whether that's all the IRQs the HW has for this HW module, I don't know.
next prev parent reply other threads:[~2014-10-26 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 13:20 [PATCH] bcm2835: add VideoCore Mailbox to the device tree Lubomir Rintel
2014-10-24 15:53 ` Lee Jones
2014-10-26 2:52 ` Stephen Warren [this message]
2014-10-26 15:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544C6204.50607@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).