From: suravee.suthikulpanit@amd.com (Suravee Suthikulanit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] arm64: amd-seattle: Adding device tree for AMD Seattle platform
Date: Mon, 27 Oct 2014 14:14:44 -0500 [thread overview]
Message-ID: <544E99A4.4020906@amd.com> (raw)
In-Reply-To: <2202046.Qx9l5PJfzL@wuerfel>
On 10/27/2014 2:07 PM, Arnd Bergmann wrote:
> On Monday 27 October 2014 13:54:25 suravee.suthikulpanit at amd.com wrote:
>> + sata0: sata at 00300000 {
>> + compatible = "snps,spear-ahci";
>> + reg = <0 0x300000 0 0x800>;
>> + interrupts = <0 355 4>;
>> + clocks = <&sataclk_333mhz>;
>> + clock-names = "apb_pclk";
>> + dma-coherent;
>> + };
>
> Please use "snps,dwc-ahci" as the compatible string for a designware
> ahci controller, not "snps,spear-ahci", which refers to the implementation
> of that in the ST microelectronics SPEAr consumer SoC.
>
> It would be good to also add a string that is specific for your SoC if
> we ever need to identify it directly.
>
> Arnd
>
Thanks. I will update this in V3.
Suravee
prev parent reply other threads:[~2014-10-27 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 18:54 [PATCH V2] arm64: amd-seattle: Adding device tree for AMD Seattle platform suravee.suthikulpanit at amd.com
2014-10-27 19:07 ` Arnd Bergmann
2014-10-27 19:14 ` Suravee Suthikulanit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E99A4.4020906@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).