From: tthayer@opensource.altera.com (Thor Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework
Date: Mon, 27 Oct 2014 17:48:17 -0500 [thread overview]
Message-ID: <544ECBB1.2040600@opensource.altera.com> (raw)
In-Reply-To: <20141027215908.GC4741@pd.tnic>
On 10/27/2014 04:59 PM, Borislav Petkov wrote:
> On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote:
>> Should I move the EDAC Device probe and error handling from
>> altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models
>> in the same file?
> Right, for basic practical reasons, I'd like to keep all functionality
> pertaining to one hw flavour in one compilation unit/one driver. We can
> always split them later if a compelling reason emerges.
>
> Thanks.
>
OK. I will make the changes.
Would the L2 cache and OCRAM specific functions also be in
altera_edac.c? Each of these EDAC pieces is independent and can be
compiled in without the others. I've read that the use of #ifdef's is
discouraged and having separate files in the Makefile solves that.
Thanks for the clarification.
Thor
next prev parent reply other threads:[~2014-10-27 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 20:33 [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework tthayer at opensource.altera.com
2014-10-17 20:33 ` [PATCHv2 1/4] arm: socfpga: Enable L2 Cache ECC on startup tthayer at opensource.altera.com
2014-10-17 20:33 ` [PATCHv2 2/4] arm: socfpga: Enable OCRAM " tthayer at opensource.altera.com
2014-10-17 20:33 ` [PATCHv2 3/4] edac: altera: Add Altera L2 and OCRAM EDAC support tthayer at opensource.altera.com
2014-10-17 20:33 ` [PATCHv2 4/4] arm: dts: Add Altera L2 Cache and OCRAM EDAC tthayer at opensource.altera.com
2014-10-27 18:50 ` [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework Thor Thayer
2014-10-27 20:43 ` Borislav Petkov
2014-10-27 21:35 ` Thor Thayer
2014-10-27 21:59 ` Borislav Petkov
2014-10-27 22:48 ` Thor Thayer [this message]
2014-10-30 15:22 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544ECBB1.2040600@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).