* [PATCH v2 04/36] ncr5380: Remove unused macros
[not found] <20141027052607.105914311@telegraphics.com.au>
@ 2014-10-27 5:26 ` Finn Thain
2014-10-27 5:26 ` [PATCH v2 08/36] ncr5380: Remove redundant AUTOSENSE macro Finn Thain
` (5 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Finn Thain @ 2014-10-27 5:26 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-unused-macros
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/e8e178fd/attachment.ksh>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 08/36] ncr5380: Remove redundant AUTOSENSE macro
[not found] <20141027052607.105914311@telegraphics.com.au>
2014-10-27 5:26 ` [PATCH v2 04/36] ncr5380: Remove unused macros Finn Thain
@ 2014-10-27 5:26 ` Finn Thain
2014-10-29 15:57 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 10/36] ncr5380: Fix SCSI_IRQ_NONE bugs Finn Thain
` (4 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Finn Thain @ 2014-10-27 5:26 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-AUTOSENSE-macro
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/af78933c/attachment.ksh>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 10/36] ncr5380: Fix SCSI_IRQ_NONE bugs
[not found] <20141027052607.105914311@telegraphics.com.au>
2014-10-27 5:26 ` [PATCH v2 04/36] ncr5380: Remove unused macros Finn Thain
2014-10-27 5:26 ` [PATCH v2 08/36] ncr5380: Remove redundant AUTOSENSE macro Finn Thain
@ 2014-10-27 5:26 ` Finn Thain
2014-10-29 16:07 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 12/36] ncr5380: Cleanup host info() methods Finn Thain
` (3 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Finn Thain @ 2014-10-27 5:26 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-SCSI_IRQ_NONE-fixes
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/64a29530/attachment.ksh>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 12/36] ncr5380: Cleanup host info() methods
[not found] <20141027052607.105914311@telegraphics.com.au>
` (2 preceding siblings ...)
2014-10-27 5:26 ` [PATCH v2 10/36] ncr5380: Fix SCSI_IRQ_NONE bugs Finn Thain
@ 2014-10-27 5:26 ` Finn Thain
2014-10-29 16:17 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data Finn Thain
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Finn Thain @ 2014-10-27 5:26 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-info-methods
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/1fe33baa/attachment.ksh>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data
[not found] <20141027052607.105914311@telegraphics.com.au>
` (3 preceding siblings ...)
2014-10-27 5:26 ` [PATCH v2 12/36] ncr5380: Cleanup host info() methods Finn Thain
@ 2014-10-27 5:26 ` Finn Thain
2014-10-30 7:31 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 15/36] ncr5380: Remove *_RELEASE macros Finn Thain
2014-10-27 5:26 ` [PATCH v2 16/36] ncr5380: Drop legacy scsi.h include Finn Thain
6 siblings, 1 reply; 13+ messages in thread
From: Finn Thain @ 2014-10-27 5:26 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-move-pdma-spin-counters
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/c339c137/attachment.ksh>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 15/36] ncr5380: Remove *_RELEASE macros
[not found] <20141027052607.105914311@telegraphics.com.au>
` (4 preceding siblings ...)
2014-10-27 5:26 ` [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data Finn Thain
@ 2014-10-27 5:26 ` Finn Thain
2014-10-30 7:36 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 16/36] ncr5380: Drop legacy scsi.h include Finn Thain
6 siblings, 1 reply; 13+ messages in thread
From: Finn Thain @ 2014-10-27 5:26 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-RELEASE-macros
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/640e2258/attachment.ksh>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 16/36] ncr5380: Drop legacy scsi.h include
[not found] <20141027052607.105914311@telegraphics.com.au>
` (5 preceding siblings ...)
2014-10-27 5:26 ` [PATCH v2 15/36] ncr5380: Remove *_RELEASE macros Finn Thain
@ 2014-10-27 5:26 ` Finn Thain
2014-10-30 7:37 ` Hannes Reinecke
6 siblings, 1 reply; 13+ messages in thread
From: Finn Thain @ 2014-10-27 5:26 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-drop-legacy-scsi-h-include
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/4dc922b3/attachment.ksh>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 08/36] ncr5380: Remove redundant AUTOSENSE macro
2014-10-27 5:26 ` [PATCH v2 08/36] ncr5380: Remove redundant AUTOSENSE macro Finn Thain
@ 2014-10-29 15:57 ` Hannes Reinecke
0 siblings, 0 replies; 13+ messages in thread
From: Hannes Reinecke @ 2014-10-29 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On 10/27/2014 06:26 AM, Finn Thain wrote:
> Every NCR5380 driver sets AUTOSENSE so it need not be optional (and the
> mid-layer expects it). Remove this redundant macro to improve readability.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 10/36] ncr5380: Fix SCSI_IRQ_NONE bugs
2014-10-27 5:26 ` [PATCH v2 10/36] ncr5380: Fix SCSI_IRQ_NONE bugs Finn Thain
@ 2014-10-29 16:07 ` Hannes Reinecke
0 siblings, 0 replies; 13+ messages in thread
From: Hannes Reinecke @ 2014-10-29 16:07 UTC (permalink / raw)
To: linux-arm-kernel
On 10/27/2014 06:26 AM, Finn Thain wrote:
> Oak scsi doesn't use any IRQ, but it sets irq = IRQ_NONE rather than
> SCSI_IRQ_NONE. Problem is, the core NCR5380 driver expects SCSI_IRQ_NONE
> if it is to issue IDENTIFY commands that prevent target disconnection.
> And, as Geert points out, IRQ_NONE is part of enum irqreturn.
>
> Other drivers, when they can't get an IRQ or can't use one, will set
> host->irq = SCSI_IRQ_NONE (that is, 255). But when they exit they will
> attempt to free IRQ 255 which was never requested.
>
> Fix these bugs by using NO_IRQ in place of SCSI_IRQ_NONE and IRQ_NONE.
> That means IRQ 0 is no longer probed by ISA drivers but I don't think
> this matters.
>
> Setting IRQ = 255 for these ISA drivers is understood to mean no IRQ.
> This remains supported so as to avoid breaking existing ISA setups (which
> can be difficult to get working) and because existing documentation
> (SANE, TLDP etc) describes this usage for the ISA NCR5380 driver options.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 12/36] ncr5380: Cleanup host info() methods
2014-10-27 5:26 ` [PATCH v2 12/36] ncr5380: Cleanup host info() methods Finn Thain
@ 2014-10-29 16:17 ` Hannes Reinecke
0 siblings, 0 replies; 13+ messages in thread
From: Hannes Reinecke @ 2014-10-29 16:17 UTC (permalink / raw)
To: linux-arm-kernel
On 10/27/2014 06:26 AM, Finn Thain wrote:
> If the host->info() method is not set, then host->name is used by default.
> For atari_scsi, that is exactly the same text. So remove the redundant
> info() method. Keep sun3_scsi.c in line with atari_scsi.
>
> Some NCR5380 drivers return an empty string from the info() method
> (arm/cumana_1.c arm/oak.c mac_scsi.c) while other drivers use the default
> (dmx3191d dtc.c g_NCR5380.c pas16.c t128.c).
>
> Implement a common info() method to replace a lot of duplicated code which
> the various drivers use to announce the same information.
>
> This replaces most of the (deprecated) show_info() output and all of the
> NCR5380_print_info() output. This also eliminates a bunch of code in
> g_NCR5380 which just duplicates functionality in the core driver.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data
2014-10-27 5:26 ` [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data Finn Thain
@ 2014-10-30 7:31 ` Hannes Reinecke
0 siblings, 0 replies; 13+ messages in thread
From: Hannes Reinecke @ 2014-10-30 7:31 UTC (permalink / raw)
To: linux-arm-kernel
On 10/27/2014 06:26 AM, Finn Thain wrote:
> Static variables from dtc.c and pas16.c should not appear in the core
> NCR5380.c driver. Aside from being a layering issue this worsens the
> divergence between the three core driver variants (atari_NCR5380.c and
> sun3_NCR5380.c don't support PSEUDO_DMA) and it can mean multiple hosts
> share the same counters.
>
> Fix this by making the pseudo DMA spin counters in the core more generic.
> This also avoids the abuse of the {DTC,PAS16}_PUBLIC_RELEASE macros, so
> they can be removed.
>
> oak.c doesn't use PDMA and hence it doesn't use the counters and hence it
> needs no write_info() method. Remove it.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 15/36] ncr5380: Remove *_RELEASE macros
2014-10-27 5:26 ` [PATCH v2 15/36] ncr5380: Remove *_RELEASE macros Finn Thain
@ 2014-10-30 7:36 ` Hannes Reinecke
0 siblings, 0 replies; 13+ messages in thread
From: Hannes Reinecke @ 2014-10-30 7:36 UTC (permalink / raw)
To: linux-arm-kernel
On 10/27/2014 06:26 AM, Finn Thain wrote:
> The *_RELEASE macros don't tell me anything. In some cases the version in
> the macro contradicts the version in the comments. Anyway, the Linux kernel
> version is sufficient information. Remove these macros to improve readability.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 16/36] ncr5380: Drop legacy scsi.h include
2014-10-27 5:26 ` [PATCH v2 16/36] ncr5380: Drop legacy scsi.h include Finn Thain
@ 2014-10-30 7:37 ` Hannes Reinecke
0 siblings, 0 replies; 13+ messages in thread
From: Hannes Reinecke @ 2014-10-30 7:37 UTC (permalink / raw)
To: linux-arm-kernel
On 10/27/2014 06:26 AM, Finn Thain wrote:
> Convert Scsi_Cmnd to struct scsi_cmnd and drop the #include "scsi.h".
> The sun3_NCR5380.c core driver already uses struct scsi_cmnd so converting
> the other core drivers reduces the diff which makes them easier to unify.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Yippie! I was waiting for that to happen.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-10-30 7:37 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20141027052607.105914311@telegraphics.com.au>
2014-10-27 5:26 ` [PATCH v2 04/36] ncr5380: Remove unused macros Finn Thain
2014-10-27 5:26 ` [PATCH v2 08/36] ncr5380: Remove redundant AUTOSENSE macro Finn Thain
2014-10-29 15:57 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 10/36] ncr5380: Fix SCSI_IRQ_NONE bugs Finn Thain
2014-10-29 16:07 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 12/36] ncr5380: Cleanup host info() methods Finn Thain
2014-10-29 16:17 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data Finn Thain
2014-10-30 7:31 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 15/36] ncr5380: Remove *_RELEASE macros Finn Thain
2014-10-30 7:36 ` Hannes Reinecke
2014-10-27 5:26 ` [PATCH v2 16/36] ncr5380: Drop legacy scsi.h include Finn Thain
2014-10-30 7:37 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).