linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: KVM: fix unmapping with 48-bit VAs
Date: Thu, 30 Oct 2014 09:23:01 +0000	[thread overview]
Message-ID: <54520375.4070907@arm.com> (raw)
In-Reply-To: <CAMJs5B-i952jh-0Wgu8tpkNVS2JHp85KPFzcR0tacgfq8oH2AA@mail.gmail.com>

On 30/10/14 09:15, Christoffer Dall wrote:
> On Thu, Oct 30, 2014 at 10:08 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> On 30/10/14 09:00, Christoffer Dall wrote:
>>> On Wed, Oct 29, 2014 at 10:39:45AM +0000, Marc Zyngier wrote:
>>>> Hi Mark,
>>>>
>>>> On 28/10/14 19:36, Mark Rutland wrote:
>>>>> Hi All,
>>>>>
>>>>> I'm not at all familiar with this code, so my analysis below might be off. Does
>>>>> this look right or am I just masking a more fundamental issue?
>>>>>
>>>>> I've given this a go with 4KiB pages on Juno with {39,48}-bit VAs and the
>>>>> system seems to boot fine.
>>>>
>>>> Thanks for looking into this.
>>>>
>>>
>>> yeah, sorry for missing this!
>>>
>>> [...]
>>>
>>>>
>>>> Looks good to me!
>>>>
>>>> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>>>>
>>>> Christoffer, if you're OK with that one, I'll queue it up for the next -rc.
>>>>
>>> Yup (for the record we're not breaking anything because 48 bit VA still
>>> depends on broken, right?):
>>
>> Since 04f905a (arm64: Allow 48-bits VA space without ARM_SMMU), we can
>> select 48bit VA if the SMMU is not selected.
>>
> Did Catlin merge this separately or did I accidentally do that?  I
> thought we were holding off on that until we had done more testing...

Catalin felt very brave, did some testing (LTP and stuff), fixed another
nit (3dec0fe), sent a pull request to Linus and went on holiday!

So far, it looks good. :-)

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2014-10-30  9:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 19:36 [PATCH] arm64: KVM: fix unmapping with 48-bit VAs Mark Rutland
2014-10-29 10:39 ` Marc Zyngier
2014-10-30  9:00   ` Christoffer Dall
2014-10-30  9:08     ` Marc Zyngier
2014-10-30  9:15       ` Christoffer Dall
2014-10-30  9:23         ` Marc Zyngier [this message]
2014-10-30  9:29           ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54520375.4070907@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).