From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] regulator: Document binding for regulator suspend voltage
Date: Sat, 01 Nov 2014 09:45:46 +0100 [thread overview]
Message-ID: <54549DBA.5020102@collabora.co.uk> (raw)
In-Reply-To: <1414813978-32233-1-git-send-email-dianders@chromium.org>
Hello Doug,
On 11/01/2014 04:52 AM, Doug Anderson wrote:
> This patch builds upon (291d761 regulator: Document binding for
> regulator suspend state for PM state) to allow setting the uV in
> addition to the state at suspend time.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> index aaad615..4e7ed76 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> @@ -28,6 +28,8 @@ Optional properties:
> - regulator-state-[mem/disk] node has following common properties:
> - regulator-on-in-suspend: regulator should be on in suspend state.
> - regulator-off-in-suspend: regulator should be off in suspend state.
> + - regulator-suspend-microvolt: regulator should be set to this voltage
> + in suspend.
The patch looks good to me:
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
On thing I wonder is if the binding should say that the suspend voltage is
independent of the runtime one and it may be outside of the runtime range?
Best regards,
Javier
next prev parent reply other threads:[~2014-11-01 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 3:52 [PATCH 1/2] regulator: Document binding for regulator suspend voltage Doug Anderson
2014-11-01 3:52 ` [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state Doug Anderson
2014-11-01 8:49 ` Javier Martinez Canillas
2014-11-03 0:27 ` Chris Zhong
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:45 ` Javier Martinez Canillas
2014-11-03 12:47 ` Mark Brown
2014-11-01 8:45 ` Javier Martinez Canillas [this message]
2014-11-03 0:27 ` [PATCH 1/2] regulator: Document binding for regulator suspend voltage Chris Zhong
2014-11-03 12:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54549DBA.5020102@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).