[PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

Antoine Ténart
2014-07-16T09:15:33Z

Hi Arnd,

On Wed, Jul 16, 2014 at 10:41:10AM +0200, Arnd Bergmann wrote:
> On Wednesday 16 July 2014 10:26:01 Antoine T?nart wrote:
> > +
> > + if (priv->dma_mask) {
> > + ret = dma_coerce_mask_and_coherent(&pdev->dev, priv->dma_mask);
> > + if (ret)
> > + return ret;
> > + }
> > +
> >
>
> As mentioned in my comment for the binding, this is the wrong way to do it.
> Russell has in the past converted all drivers that did this manually to
> do dma_coerce_mask_and_coherent() so we can spot them more easily, but we
> should really be doing this better for new drivers.
>
> Can you describe what the restriction is that you want to put on the dma mask?

Some people wanted the possibility to set the DMA mask as this USB2 CI
driver does not do specific Berlin operation and can be reused later.
I don't particularly need to call dma_coerce_mask_and_coherent() in my
case, as far as I know.

They can maybe give the restrictions they might want to put on the DMA
mask.

Antoine

--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering