[PATCH v3 05/12] phy: add the Berlin USB PHY driver

Antoine Ténart
2014-07-16T09:25:41Z

Hi Varka,

On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote:
> On 07/16/2014 01:55 PM, Antoine T?nart wrote:
> >+static const struct of_device_id phy_berlin_sata_of_match[] = {
> >+ {
> >+ .compatible = "marvell,berlin2-usb-phy",
> >+ .data = &phy_berlin_pll_dividers[0],
> >+ },
> >+ {
> >+ .compatible = "marvell,berlin2cd-usb-phy",
> >+ .data = &phy_berlin_pll_dividers[1],
> >+ },
> >+ { },
> >+};
> >+MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
> >+
>
> It looks good if we move this after probe().. So that we can see of_match_table directly...

We use the of match table in the probe, when calling of_match_device().

> >+static int phy_berlin_usb_probe(struct platform_device *pdev)
> >+{
> >+ const struct of_device_id *match =
> >+ of_match_device(phy_berlin_sata_of_match, &pdev->dev);

Here.

Antoine

> >+ struct phy_berlin_usb_priv *priv;
> >+ struct resource *res;
> >+ struct phy_provider *phy_provider;
> >+
> >+ priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> >+ if (!priv)
> >+ return -ENOMEM;
> >+
> >+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >+ priv->base = devm_ioremap_resource(&pdev->dev, res);
> >+ if (IS_ERR(priv->base))
> >+ return PTR_ERR(priv->base);
> >+
> >+ priv->rst_ctrl = devm_reset_control_get(&pdev->dev, NULL);
> >+ if (IS_ERR(priv->rst_ctrl))
> >+ return PTR_ERR(priv->rst_ctrl);
> >+
> >+ priv->pll_divider = *((u32 *)match->data);
> >+
> >+ priv->phy = devm_phy_create(&pdev->dev, &phy_berlin_usb_ops, NULL);
> >+ if (IS_ERR(priv->phy)) {
> >+ dev_err(&pdev->dev, "failed to create PHY\n");
> >+ return PTR_ERR(priv->phy);
> >+ }
> >+
> >+ platform_set_drvdata(pdev, priv);
> >+
> >+ phy_provider =
> >+ devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate);
> >+ if (IS_ERR(phy_provider))
> >+ return PTR_ERR(phy_provider);
> >+
> >+ return 0;
> >+}

--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering