linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: BCM5301X: set customized AUXCTL
Date: Mon, 03 Nov 2014 15:39:28 -0800	[thread overview]
Message-ID: <54581230.9090205@gmail.com> (raw)
In-Reply-To: <54580CD9.3050309@hauke-m.de>

On 11/03/2014 03:16 PM, Hauke Mehrtens wrote:
> On 11/03/2014 11:00 AM, Arnd Bergmann wrote:
>> On Saturday 01 November 2014 15:41:38 Hauke Mehrtens wrote:
>>>  };
>>>  
>>>  DT_MACHINE_START(BCM5301X, "BCM5301X")
>>> -       .l2c_aux_val    = 0,
>>> +       .l2c_aux_val    = L310_AUX_CTRL_CACHE_REPLACE_RR |
>>> +                         L310_AUX_CTRL_DATA_PREFETCH |
>>> +                         L310_AUX_CTRL_INSTR_PREFETCH |
>>> +                         L310_AUX_CTRL_EARLY_BRESP,
>>
>> Please put these into the dts file instead if the boot loader fails
>> to set them correctly. We should not override them from source code
>> for new platforms any more.
> I checked again and I only need L310_AUX_CTRL_DATA_PREFETCH and
> L310_AUX_CTRL_INSTR_PREFETCH, the others get activate by the existing
> code. Should I make it possible to give l2c_aux_val through dt, or
> should I create some boolean options for  L310_AUX_CTRL_DATA_PREFETCH
> and  L310_AUX_CTRL_INSTR_PREFETCH?

Last we talked about these prefetch bits with Russell, I think we kind
of agreed that they could probably be enabled by default

There is already a large number of properties defined in
Documentation/devicetree/bindings/arm/l2cc.txt, I suppose that having
prefetch properties could work too.
--
Florian

  reply	other threads:[~2014-11-03 23:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-01 14:25 [PATCH] ARM: BCM53XX: set customized AUXCTL Hauke Mehrtens
2014-11-01 14:41 ` [PATCH v2] ARM: BCM5301X: " Hauke Mehrtens
2014-11-03 10:00   ` Arnd Bergmann
2014-11-03 23:16     ` Hauke Mehrtens
2014-11-03 23:39       ` Florian Fainelli [this message]
2014-11-04 10:22         ` Arnd Bergmann
2014-11-08 13:58           ` Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54581230.9090205@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).