linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hansverk@cisco.com (Hans Verkuil)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/15] [media] Move mediabus format definition to a more standard place
Date: Tue, 04 Nov 2014 11:22:47 +0100	[thread overview]
Message-ID: <5458A8F7.2050803@cisco.com> (raw)
In-Reply-To: <5458A878.3010809@cisco.com>



On 11/04/14 11:20, Hans Verkuil wrote:
> Hi Boris,
> 
> On 11/04/14 10:54, Boris Brezillon wrote:
>> Rename mediabus formats and move the enum into a separate header file so
>> that it can be used by DRM/KMS subsystem without any reference to the V4L2
>> subsystem.
>>
>> Old V4L2_MBUS_FMT_ definitions are now referencing MEDIA_BUS_FMT_ value.
> 
> I missed earlier that v4l2-mediabus.h contained a struct as well, so it can't be
> deprecated and neither can a #warning be added.
> 
> The best approach, I think, is to use a macro in media-bus-format.h
> that will either define just the MEDIA_BUS value when compiled in the kernel, or
> define both MEDIA_BUS and V4L2_MBUS values when compiled for userspace.
> 
> E.g. something like this:
> 
> #ifdef __KERNEL__
> #define MEDIA_BUS_FMT_ENTRY(name, val) MEDIA_BUS_FMT_ # name = val
> #else
> /* Keep V4L2_MBUS_FMT for backwards compatibility */
> #define MEDIA_BUS_FMT_ENTRY(name, val) \
> 	MEDIA_BUS_FMT_ # name = val, \
> 	V4L2_MBUS_FMT_ # name = val
> #endif

And v4l2-mediabus.h needs this as well:

#ifndef __KERNEL__
/* For backwards compatibility */
#define v4l2_mbus_pixelcode media_bus_format
#endif

Regards,

	Hans

  reply	other threads:[~2014-11-04 10:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  9:54 [PATCH 00/15] [media] Make mediabus format subsystem neutral Boris Brezillon
2014-11-04  9:54 ` [PATCH 01/15] [media] Move mediabus format definition to a more standard place Boris Brezillon
2014-11-04 10:20   ` Hans Verkuil
2014-11-04 10:22     ` Hans Verkuil [this message]
2014-11-04 10:45     ` Boris Brezillon
2014-11-04 11:09       ` Hans Verkuil
2014-11-05 15:00         ` Sakari Ailus
2014-11-05 15:32           ` Boris Brezillon
2014-11-04  9:54 ` [PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values Boris Brezillon
2014-11-05 14:57   ` Sakari Ailus
2014-11-05 15:01     ` Boris Brezillon
2014-11-04  9:54 ` [PATCH 03/15] [media] Make use of the new media_bus_format definitions Boris Brezillon
2014-11-05 15:19   ` Sakari Ailus
2014-11-04  9:54 ` [PATCH 04/15] [media] i2c: Make use of media_bus_format enum Boris Brezillon
2014-11-04  9:55 ` [PATCH 05/15] [media] pci: " Boris Brezillon
2014-11-04  9:55 ` [PATCH 07/15] [media] usb: " Boris Brezillon
2014-11-04  9:55 ` [PATCH 08/15] staging: media: " Boris Brezillon
2014-11-04  9:55 ` [PATCH 09/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04  9:55 ` [PATCH 10/15] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel Boris Brezillon
2014-11-04  9:55 ` [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode Boris Brezillon
2014-11-05 15:08   ` Sakari Ailus
2014-11-05 15:15     ` Boris Brezillon
2014-11-05 15:19       ` Hans Verkuil
2014-11-05 15:30         ` Boris Brezillon
2014-11-05 15:34           ` Hans Verkuil
2014-11-05 15:22       ` Sakari Ailus
2014-11-04  9:55 ` [PATCH 12/15] [media] i2c: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h Boris Brezillon
2014-11-04  9:55 ` [PATCH 13/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04  9:55 ` [PATCH 14/15] [media] platform: " Boris Brezillon
2014-11-04  9:55 ` [PATCH 15/15] staging: media: " Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5458A8F7.2050803@cisco.com \
    --to=hansverk@cisco.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).