From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: kvm: eliminate literal pool entries
Date: Fri, 07 Nov 2014 14:44:28 +0000 [thread overview]
Message-ID: <545CDACC.5070406@arm.com> (raw)
In-Reply-To: <1415369554-7444-2-git-send-email-ard.biesheuvel@linaro.org>
On 07/11/14 14:12, Ard Biesheuvel wrote:
> Replace two instances of 'ldr xN, =(constant)' in the world switch
> hot path with 'mov' instructions.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm64/kvm/hyp.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp.S b/arch/arm64/kvm/hyp.S
> index b72aa9f9215c..fbe909fb0a1a 100644
> --- a/arch/arm64/kvm/hyp.S
> +++ b/arch/arm64/kvm/hyp.S
> @@ -761,10 +761,10 @@
> .macro activate_traps
> ldr x2, [x0, #VCPU_HCR_EL2]
> msr hcr_el2, x2
> - ldr x2, =(CPTR_EL2_TTA)
> + mov x2, #CPTR_EL2_TTA
> msr cptr_el2, x2
>
> - ldr x2, =(1 << 15) // Trap CP15 Cr=15
> + mov x2, #(1 << 15) // Trap CP15 Cr=15
> msr hstr_el2, x2
>
> mrs x2, mdcr_el2
>
Looks good to me.
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-11-07 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 14:12 [PATCH 1/2] arm64: ftrace: eliminate literal pool entries Ard Biesheuvel
2014-11-07 14:12 ` [PATCH 2/2] arm64: kvm: " Ard Biesheuvel
2014-11-07 14:44 ` Marc Zyngier [this message]
2014-11-07 14:51 ` Christoffer Dall
2014-11-07 15:03 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545CDACC.5070406@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).