From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [REPOST PATCH 1/2] ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks
Date: Fri, 7 Nov 2014 19:13:49 +0200 [thread overview]
Message-ID: <545CFDCD.5090006@ti.com> (raw)
In-Reply-To: <20141107152201.GS8509@sirena.org.uk>
On 11/07/2014 05:22 PM, Mark Brown wrote:
> On Fri, Oct 10, 2014 at 05:06:28PM +0300, Tero Kristo wrote:
>
>> - dev->platform_data = &twl_gpio_auxdata;
>> + if (!strcmp("twl4030-gpio", dev_name(dev)))
>> + dev->platform_data = &twl_gpio_auxdata;
>> + else
>> + dev->platform_data = omap_twl_match_regulator(dev);
>
> Looking at this idiom here I'd expect that we'd be adding another string
> comparison here?
We are actually doing an of_match_node call within the
twl_match_regulator. However, we had a short offline discussion with
Tony, and this whole function should be fixed to check node
compatibility instead of dev_name. I will be posting a new version that
does this once I have time to look at it.
What do you think of patch #2 though? Thats more interesting for the
regulator driver purposes and if you NAK that one, the floor goes under
this whole approach.
-Tero
next prev parent reply other threads:[~2014-11-07 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 14:06 [REPOST PATCH 0/2] ARM: OMAP3+: VCVP mapping fixes to get DVFS working Tero Kristo
2014-10-10 14:06 ` [REPOST PATCH 1/2] ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks Tero Kristo
2014-11-07 15:22 ` Mark Brown
2014-11-07 17:13 ` Tero Kristo [this message]
2014-10-10 14:06 ` [REPOST PATCH 2/2] regulator: twl: use platform data in the DT based boot also Tero Kristo
2014-10-16 14:21 ` [REPOST PATCH 0/2] ARM: OMAP3+: VCVP mapping fixes to get DVFS working Enric Balletbo Serra
2014-10-17 5:55 ` Tero Kristo
2014-10-17 11:55 ` Enric Balletbo Serra
2014-10-17 12:35 ` Tero Kristo
2014-10-17 12:48 ` Enric Balletbo Serra
2014-10-17 13:54 ` Nishanth Menon
2014-10-17 13:56 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545CFDCD.5090006@ti.com \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).