From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB34BC47422 for ; Mon, 29 Jan 2024 09:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wht0LO9rcj4h2GM0aHYxBNFEWDJhnWUxb2Wy5swRaHc=; b=3HxcTJ/O24+3m7 9AAJ1gmQmOmxxvAnMUEkmCVf/egdFDvHe8tUpbJxU0DTWPbdhJ/3yyK4Hy84mo/Z8Y/62bveiLtGK 1HIUBp2P9lWC2IPPK0ORBzaq3ER8FWm/bElmag2pQXr+/kvYQ5J4x4cCm+fJd/+78P14vsTb1n4hT xFdHmlPc3AjLK26LohzsGv3ss9NoOcagAqyBd76bwQ8YXuqlS/hQxkrqyATVlUlUOje473f3x/GgP TtNexJJNTI5G6bPTq9hCiZ0ZBuzlo4poa6nIXJI9XwrrMqJhw6iA4rRSkVULuNAnVq0vopkESwsHE VzgSMTa5H4Pzon+yp9YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUNzW-0000000C2nL-1D6M; Mon, 29 Jan 2024 09:31:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUNzS-0000000C2lT-1jam for linux-arm-kernel@lists.infradead.org; Mon, 29 Jan 2024 09:31:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0F771FB; Mon, 29 Jan 2024 01:32:21 -0800 (PST) Received: from [10.162.42.11] (a077893.blr.arm.com [10.162.42.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1DA1E3F762; Mon, 29 Jan 2024 01:31:26 -0800 (PST) Message-ID: <545bb7bd-31c7-4166-9f81-778b82ece6d4@arm.com> Date: Mon, 29 Jan 2024 15:01:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 07/35] mm: cma: Add CMA_RELEASE_{SUCCESS,FAIL} events Content-Language: en-US To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-8-alexandru.elisei@arm.com> From: Anshuman Khandual In-Reply-To: <20240125164256.4147-8-alexandru.elisei@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240129_013142_646160_784E3CE9 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/25/24 22:12, Alexandru Elisei wrote: > Similar to the two events that relate to CMA allocations, add the > CMA_RELEASE_SUCCESS and CMA_RELEASE_FAIL events that count when CMA pages > are freed. How is this is going to be beneficial towards analyzing CMA alloc/release behaviour - particularly with respect to this series. OR just adding this from parity perspective with CMA alloc side counters ? Regardless this CMA change too could be discussed separately. > > Signed-off-by: Alexandru Elisei > --- > > Changes since rfc v2: > > * New patch. > > include/linux/vm_event_item.h | 2 ++ > mm/cma.c | 6 +++++- > mm/vmstat.c | 2 ++ > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index 747943bc8cc2..aba5c5bf8127 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -83,6 +83,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > #ifdef CONFIG_CMA > CMA_ALLOC_SUCCESS, > CMA_ALLOC_FAIL, > + CMA_RELEASE_SUCCESS, > + CMA_RELEASE_FAIL, > #endif > UNEVICTABLE_PGCULLED, /* culled to noreclaim list */ > UNEVICTABLE_PGSCANNED, /* scanned for reclaimability */ > diff --git a/mm/cma.c b/mm/cma.c > index dbf7fe8cb1bd..543bb6b3be8e 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -562,8 +562,10 @@ bool cma_release(struct cma *cma, const struct page *pages, > { > unsigned long pfn; > > - if (!cma_pages_valid(cma, pages, count)) > + if (!cma_pages_valid(cma, pages, count)) { > + count_vm_events(CMA_RELEASE_FAIL, count); > return false; > + } > > pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, count); > > @@ -575,6 +577,8 @@ bool cma_release(struct cma *cma, const struct page *pages, > cma_clear_bitmap(cma, pfn, count); > trace_cma_release(cma->name, pfn, pages, count); > > + count_vm_events(CMA_RELEASE_SUCCESS, count); > + > return true; > } > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index db79935e4a54..eebfd5c6c723 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1340,6 +1340,8 @@ const char * const vmstat_text[] = { > #ifdef CONFIG_CMA > "cma_alloc_success", > "cma_alloc_fail", > + "cma_release_success", > + "cma_release_fail", > #endif > "unevictable_pgs_culled", > "unevictable_pgs_scanned", _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel