From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee.Suthikulpanit@amd.com (Suravee Suthikulpanit) Date: Wed, 12 Nov 2014 18:36:07 +0700 Subject: [PATCH V2 2/2] PCI: generic: Add msi_parent DT binding In-Reply-To: References: <1415733454-24322-1-git-send-email-suravee.suthikulpanit@amd.com> <1415733454-24322-3-git-send-email-suravee.suthikulpanit@amd.com> Message-ID: <54634627.60502@amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/12/14 13:56, Srikanth Thokala wrote: >> @@ -122,9 +123,19 @@ static int gen_pci_config_write(struct pci_bus *bus, unsigned int devfn, >> > return PCIBIOS_SUCCESSFUL; >> > } >> > >> >+static int gen_pci_set_msi_parent(struct pci_bus *bus) >> >+{ >> >+ struct gen_pci *pci = bus_to_gen_pci(bus); >> >+ >> >+ bus->msi = pci->mchip; >> >+ >> >+ return PCIBIOS_SUCCESSFUL; >> >+} >> >+ >> > static struct pci_ops gen_pci_ops = { >> > .read = gen_pci_config_read, >> > .write = gen_pci_config_write, >> >+ .set_msi_parent = gen_pci_set_msi_parent, > We assign the msi chip through add_bus() call, do we still need this? Certain architecture (i.e arm64) doesn't implement struct hw_pci. Therefore, there is no add_bus(). However, this new API should allow non-arch dependent implementation. Suravee