* [PATCH v3] of: replace Asahi Kasei Corp venter prefix [not found] ` <20141113110740.GE3815@sirena.org.uk> @ 2014-11-14 1:43 ` Kuninori Morimoto 2014-11-14 8:38 ` Alexandre Courbot 2014-11-14 9:35 ` [alsa-devel] " Thierry Reding 0 siblings, 2 replies; 22+ messages in thread From: Kuninori Morimoto @ 2014-11-14 1:43 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2cec065fef15d200a42a04130799f7 (of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975") So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v3] of: replace Asahi Kasei Corp venter prefix 2014-11-14 1:43 ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto @ 2014-11-14 8:38 ` Alexandre Courbot 2014-11-14 9:16 ` Arnd Bergmann 2014-11-14 9:30 ` Thierry Reding 2014-11-14 9:35 ` [alsa-devel] " Thierry Reding 1 sibling, 2 replies; 22+ messages in thread From: Alexandre Courbot @ 2014-11-14 8:38 UTC (permalink / raw) To: linux-arm-kernel On 11/14/2014 10:43 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current vendor-prefixes.txt already has > "ak" prefix for Asahi Kasei Corp by > ae8c4209af2cec065fef15d200a42a04130799f7 > (of: Add vendor prefix for Asahi Kasei Corp.) > > It went through the appropriate review process. > But, almost all Asahi Kasei chip drivers are > using "asahi-kasei" prefix today. > (arch/arm/boot/dts/tegra20-seaboard.dts only is > using "ak,ak8975", but there are instances of > "asahi-kasei,ak8975" in other dts files. > And drivers/iio/magnetometer/ak8975.c > doesn't support "ak,ak8975") > So, we made a mistake there. > > In addition, checkpatch.pl reports WARNING > if it is using "asahi-kasei" prerfix in DT file. > (DT compatible string vendor "asahi-kasei" appears un-documented) > > Marking it deprecated and warning with checkpatch > is certainly preferable. > So, this patch replace "ak" to "asahi-kasei" in > vendor-prefixes.txt. (and fixup tegra20-seaboard) > > OTOH, Asahi Kasei is usually referred to as "AKM", > but this patch doesn't care about it. > Because no DT is using that today. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/vendor-prefixes.txt | 2 +- > arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 723999d..ddcb4cd 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -9,7 +9,6 @@ ad Avionic Design GmbH > adapteva Adapteva, Inc. > adi Analog Devices, Inc. > aeroflexgaisler Aeroflex Gaisler AB > -ak Asahi Kasei Corp. > allwinner Allwinner Technology Co., Ltd. > altr Altera Corp. > amcc Applied Micro Circuits Corporation (APM, formally AMCC) > @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. > apm Applied Micro Circuits Corporation (APM) > arm ARM Ltd. > armadeus ARMadeus Systems SARL > +asahi-kasei Asahi Kasei Corp. > atmel Atmel Corporation > auo AU Optronics Corporation > avago Avago Technologies > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > index a1d4bf9..7f5cf80 100644 > --- a/arch/arm/boot/dts/tegra20-seaboard.dts > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts > @@ -405,7 +405,7 @@ > clock-frequency = <400000>; > > magnetometer at c { > - compatible = "ak,ak8975"; > + compatible = "asahi-kasei,ak8975"; Mmm. So does this mean this device was never probed because the driver did not recognize its compatible property? I cannot find "ak,ak8975" anywhere else in the kernel. If so, Acked-by: Alexandre Courbot <acourbot@nvidia.com> ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v3] of: replace Asahi Kasei Corp venter prefix 2014-11-14 8:38 ` Alexandre Courbot @ 2014-11-14 9:16 ` Arnd Bergmann 2014-11-14 9:30 ` Thierry Reding 1 sibling, 0 replies; 22+ messages in thread From: Arnd Bergmann @ 2014-11-14 9:16 UTC (permalink / raw) To: linux-arm-kernel On Friday 14 November 2014 17:38:58 Alexandre Courbot wrote: > > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > > index a1d4bf9..7f5cf80 100644 > > --- a/arch/arm/boot/dts/tegra20-seaboard.dts > > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts > > @@ -405,7 +405,7 @@ > > clock-frequency = <400000>; > > > > magnetometer at c { > > - compatible = "ak,ak8975"; > > + compatible = "asahi-kasei,ak8975"; > > Mmm. So does this mean this device was never probed because the driver > did not recognize its compatible property? I cannot find "ak,ak8975" > anywhere else in the kernel. > No, the i2c bus behaves in a special way by matching the "ak8975" i2c driver name with any "*,ak8975" DT compatible string. Both of the above will work with existing kernels. Arnd ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v3] of: replace Asahi Kasei Corp venter prefix 2014-11-14 8:38 ` Alexandre Courbot 2014-11-14 9:16 ` Arnd Bergmann @ 2014-11-14 9:30 ` Thierry Reding 1 sibling, 0 replies; 22+ messages in thread From: Thierry Reding @ 2014-11-14 9:30 UTC (permalink / raw) To: linux-arm-kernel On Fri, Nov 14, 2014 at 05:38:58PM +0900, Alexandre Courbot wrote: > On 11/14/2014 10:43 AM, Kuninori Morimoto wrote: [...] > >diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > >index a1d4bf9..7f5cf80 100644 > >--- a/arch/arm/boot/dts/tegra20-seaboard.dts > >+++ b/arch/arm/boot/dts/tegra20-seaboard.dts > >@@ -405,7 +405,7 @@ > > clock-frequency = <400000>; > > > > magnetometer at c { > >- compatible = "ak,ak8975"; > >+ compatible = "asahi-kasei,ak8975"; > > Mmm. So does this mean this device was never probed because the driver did > not recognize its compatible property? I2C (like SPI) has a fallback in case the OF table yields no match. The of_modalias_node() that it uses extracts the module name from the device tree node's compatible string by skipping the vendor prefix. The resulting string is then set as the I2C client's name and causes the I2C standard ID matching to succeed (see of_i2c_register_devices() for how this is done in detail). > I cannot find "ak,ak8975" anywhere else in the kernel. > > If so, > > Acked-by: Alexandre Courbot <acourbot@nvidia.com> Technically this is breaking backwards-compatibility from a DT perspective, but I think it's safe to do because the Linux kernel has a way of dealing with this and other operating systems should be able to deal with this in a similar way (or even easier by letting the driver match on the ak prefix as well for this particular chip). So: Acked-by: Thierry Reding <treding@nvidia.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141114/28fd4c1a/attachment.sig> ^ permalink raw reply [flat|nested] 22+ messages in thread
* [alsa-devel] [PATCH v3] of: replace Asahi Kasei Corp venter prefix 2014-11-14 1:43 ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto 2014-11-14 8:38 ` Alexandre Courbot @ 2014-11-14 9:35 ` Thierry Reding 2014-11-17 0:51 ` [PATCH v4] " Kuninori Morimoto 1 sibling, 1 reply; 22+ messages in thread From: Thierry Reding @ 2014-11-14 9:35 UTC (permalink / raw) To: linux-arm-kernel On Fri, Nov 14, 2014 at 01:43:03AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current vendor-prefixes.txt already has > "ak" prefix for Asahi Kasei Corp by > ae8c4209af2cec065fef15d200a42a04130799f7 It's usually enough to show the first 12 (or so) characters of the SHA1 here. git will show you the right one if you do something like: git log --abbrev=12 --abbrev-commit It's probably useful to "git config core.abbrev 12" for Linux kernel repositories. Other than that it seems like you're being overly careful about not exceeding 72 characters. Your lines seem to wrap at around less than 50 columns. However, making lines too short results in equally hard to read commit messages, so please try to shoot for 72 columns for maximum readability. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141114/b6f807cf/attachment.sig> ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v4] of: replace Asahi Kasei Corp venter prefix 2014-11-14 9:35 ` [alsa-devel] " Thierry Reding @ 2014-11-17 0:51 ` Kuninori Morimoto 2014-11-17 10:26 ` Sergei Shtylyov 0 siblings, 1 reply; 22+ messages in thread From: Kuninori Morimoto @ 2014-11-17 0:51 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975") So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- v3 -> v4 - git-comment uses 72 char in 1 line - added Thierry/Alexandre's Acked-by .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v4] of: replace Asahi Kasei Corp venter prefix 2014-11-17 0:51 ` [PATCH v4] " Kuninori Morimoto @ 2014-11-17 10:26 ` Sergei Shtylyov 2014-11-18 0:30 ` [PATCH v5] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto 0 siblings, 1 reply; 22+ messages in thread From: Sergei Shtylyov @ 2014-11-17 10:26 UTC (permalink / raw) To: linux-arm-kernel Hello. On 11/17/2014 3:51 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> s/venter/vendor/ in the subject. Sorry for a late comment. > Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp > by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) > It went through the appropriate review process. But, almost all > Asahi Kasei chip drivers are using "asahi-kasei" prefix today. > (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", > but there are instances of "asahi-kasei,ak8975" in other dts files. > And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975") > So, we made a mistake there. > In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" > prerfix in DT file. > (DT compatible string vendor "asahi-kasei" appears un-documented) > Marking it deprecated and warning with checkpatch is certainly > preferable. So, this patch replace "ak" to "asahi-kasei" in > vendor-prefixes.txt. (and fixup tegra20-seaboard) > OTOH, Asahi Kasei is usually referred to as "AKM", but this patch > doesn't care about it. Because no DT is using that today. > Acked-by: Thierry Reding <treding@nvidia.com> > Acked-by: Alexandre Courbot <acourbot@nvidia.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> One normally places ACKs after his own sign-off. WBR, Sergei ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5] of: replace Asahi Kasei Corp vendor prefix 2014-11-17 10:26 ` Sergei Shtylyov @ 2014-11-18 0:30 ` Kuninori Morimoto 2014-11-28 0:22 ` [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto 0 siblings, 1 reply; 22+ messages in thread From: Kuninori Morimoto @ 2014-11-18 0:30 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> --- v4 -> v5 - venter -> vendor on Subject - fixup Acked-by ordering .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix 2014-11-18 0:30 ` [PATCH v5] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto @ 2014-11-28 0:22 ` Kuninori Morimoto 2014-11-28 11:45 ` Sergei Shtylyov 0 siblings, 1 reply; 22+ messages in thread From: Kuninori Morimoto @ 2014-11-28 0:22 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix 2014-11-28 0:22 ` [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto @ 2014-11-28 11:45 ` Sergei Shtylyov 2014-12-02 4:57 ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto 0 siblings, 1 reply; 22+ messages in thread From: Sergei Shtylyov @ 2014-11-28 11:45 UTC (permalink / raw) To: linux-arm-kernel Hello. On 11/28/2014 3:22 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp > by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) > It went through the appropriate review process. But, almost all > Asahi Kasei chip drivers are using "asahi-kasei" prefix today. > (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", > but there are instances of "asahi-kasei,ak8975" in other dts files. > And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) > So, we made a mistake there. > In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" > prerfix in DT file. > (DT compatible string vendor "asahi-kasei" appears un-documented) > Marking it deprecated and warning with checkpatch is certainly > preferable. So, this patch replace "ak" to "asahi-kasei" in > vendor-prefixes.txt. (and fixup tegra20-seaboard) > OTOH, Asahi Kasei is usually referred to as "AKM", but this patch > doesn't care about it. Because no DT is using that today. > Acked-by: Thierry Reding <treding@nvidia.com> > Acked-by: Alexandre Courbot <acourbot@nvidia.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> It's "venter" ISO "vendor" again in the subject. And you already fixed that in the previous posting... :-) WBR, Sergei ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix 2014-11-28 11:45 ` Sergei Shtylyov @ 2014-12-02 4:57 ` Kuninori Morimoto 2014-12-15 3:53 ` [PATCH v5][resend v2] " Kuninori Morimoto ` (3 more replies) 0 siblings, 4 replies; 22+ messages in thread From: Kuninori Morimoto @ 2014-12-02 4:57 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> --- v4 -> v5 - venter -> vendor on Subject - fixup Acked-by ordering .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5][resend v2] of: replace Asahi Kasei Corp vendor prefix 2014-12-02 4:57 ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto @ 2014-12-15 3:53 ` Kuninori Morimoto 2014-12-17 2:33 ` [PATCH v5][resend v3] " Kuninori Morimoto ` (2 subsequent siblings) 3 siblings, 0 replies; 22+ messages in thread From: Kuninori Morimoto @ 2014-12-15 3:53 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> --- Rob, Mark There is no response about this patch. Mark, is it possible to care about this patch ? It has relationship to ASoC. .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5][resend v3] of: replace Asahi Kasei Corp vendor prefix 2014-12-02 4:57 ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto 2014-12-15 3:53 ` [PATCH v5][resend v2] " Kuninori Morimoto @ 2014-12-17 2:33 ` Kuninori Morimoto 2015-01-09 3:40 ` [PATCH v5][resend v4] " Kuninori Morimoto 2014-12-25 3:55 ` [PATCH v5][resend v6] " Kuninori Morimoto 2015-01-13 20:03 ` [PATCH v5][resend] " Rob Herring 3 siblings, 1 reply; 22+ messages in thread From: Kuninori Morimoto @ 2014-12-17 2:33 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> --- >> Linus I had sent this patch to Linux ML and Maintainers many times, but, no-one cares about it. Can you please check and apply it ? .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix 2014-12-17 2:33 ` [PATCH v5][resend v3] " Kuninori Morimoto @ 2015-01-09 3:40 ` Kuninori Morimoto 2015-01-09 3:42 ` [PATCH v5][resend v5] " Kuninori Morimoto 2015-01-09 4:36 ` [PATCH v5][resend v4] " Stephen Warren 0 siblings, 2 replies; 22+ messages in thread From: Kuninori Morimoto @ 2015-01-09 3:40 UTC (permalink / raw) To: linux-arm-kernel Hi Stephen, Olof, Arnd, Rob, Andrew I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during half-year (since Jun 2014) , many times. But, no-one care it. I don't know who is the best maintainer. - Stephen : because it has Tegra ? - Olof : because it has Tegra (= ARM) ? - Arnd : because it has Tegra (= ARM) ? - Matthias: because it has Tegra (= ARM SoC) ? - Rob : because DT ? - Andrew : Last chance ? But, could you please care this patch ? I will re-send it again > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp > by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) > > It went through the appropriate review process. But, almost all > Asahi Kasei chip drivers are using "asahi-kasei" prefix today. > (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", > but there are instances of "asahi-kasei,ak8975" in other dts files. > And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) > So, we made a mistake there. > > In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" > prerfix in DT file. > (DT compatible string vendor "asahi-kasei" appears un-documented) > > Marking it deprecated and warning with checkpatch is certainly > preferable. So, this patch replace "ak" to "asahi-kasei" in > vendor-prefixes.txt. (and fixup tegra20-seaboard) > > OTOH, Asahi Kasei is usually referred to as "AKM", but this patch > doesn't care about it. Because no DT is using that today. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Thierry Reding <treding@nvidia.com> > Acked-by: Alexandre Courbot <acourbot@nvidia.com> > --- > >> Linus > > I had sent this patch to Linux ML and Maintainers many times, > but, no-one cares about it. > Can you please check and apply it ? > > > .../devicetree/bindings/vendor-prefixes.txt | 2 +- > arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 723999d..ddcb4cd 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -9,7 +9,6 @@ ad Avionic Design GmbH > adapteva Adapteva, Inc. > adi Analog Devices, Inc. > aeroflexgaisler Aeroflex Gaisler AB > -ak Asahi Kasei Corp. > allwinner Allwinner Technology Co., Ltd. > altr Altera Corp. > amcc Applied Micro Circuits Corporation (APM, formally AMCC) > @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. > apm Applied Micro Circuits Corporation (APM) > arm ARM Ltd. > armadeus ARMadeus Systems SARL > +asahi-kasei Asahi Kasei Corp. > atmel Atmel Corporation > auo AU Optronics Corporation > avago Avago Technologies > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > index a1d4bf9..7f5cf80 100644 > --- a/arch/arm/boot/dts/tegra20-seaboard.dts > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts > @@ -405,7 +405,7 @@ > clock-frequency = <400000>; > > magnetometer at c { > - compatible = "ak,ak8975"; > + compatible = "asahi-kasei,ak8975"; > reg = <0xc>; > interrupt-parent = <&gpio>; > interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; > -- > 1.7.9.5 > ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5][resend v5] of: replace Asahi Kasei Corp vendor prefix 2015-01-09 3:40 ` [PATCH v5][resend v4] " Kuninori Morimoto @ 2015-01-09 3:42 ` Kuninori Morimoto 2015-01-09 4:36 ` [PATCH v5][resend v4] " Stephen Warren 1 sibling, 0 replies; 22+ messages in thread From: Kuninori Morimoto @ 2015-01-09 3:42 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> --- v4 -> v5 - venter -> vendor on Subject - fixup Acked-by ordering .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix 2015-01-09 3:40 ` [PATCH v5][resend v4] " Kuninori Morimoto 2015-01-09 3:42 ` [PATCH v5][resend v5] " Kuninori Morimoto @ 2015-01-09 4:36 ` Stephen Warren 2015-01-09 10:07 ` Kuninori Morimoto 1 sibling, 1 reply; 22+ messages in thread From: Stephen Warren @ 2015-01-09 4:36 UTC (permalink / raw) To: linux-arm-kernel On 01/08/2015 08:40 PM, Kuninori Morimoto wrote: > > Hi Stephen, Olof, Arnd, Rob, Andrew > > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during > half-year (since Jun 2014) , many times. But, no-one care it. > I don't know who is the best maintainer. > - Stephen : because it has Tegra ? > - Olof : because it has Tegra (= ARM) ? > - Arnd : because it has Tegra (= ARM) ? > - Matthias: because it has Tegra (= ARM SoC) ? > - Rob : because DT ? > - Andrew : Last chance ? > > But, could you please care this patch ? > I will re-send it again It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively changing a DT vendor name would need that, I think. Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it seems they expect it to go through some tree other than Tegra. Weren't there a bunch of related patches along with this (e.g. updating relevant drivers to support both prefixes?) so it was expected this patch would be applied together with them? >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp >> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) >> >> It went through the appropriate review process. But, almost all >> Asahi Kasei chip drivers are using "asahi-kasei" prefix today. >> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", >> but there are instances of "asahi-kasei,ak8975" in other dts files. >> And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) >> So, we made a mistake there. >> >> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" >> prerfix in DT file. >> (DT compatible string vendor "asahi-kasei" appears un-documented) >> >> Marking it deprecated and warning with checkpatch is certainly >> preferable. So, this patch replace "ak" to "asahi-kasei" in >> vendor-prefixes.txt. (and fixup tegra20-seaboard) >> >> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch >> doesn't care about it. Because no DT is using that today. >> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> Acked-by: Thierry Reding <treding@nvidia.com> >> Acked-by: Alexandre Courbot <acourbot@nvidia.com> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt >> -ak Asahi Kasei Corp. >> +asahi-kasei Asahi Kasei Corp. >> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts >> magnetometer at c { >> - compatible = "ak,ak8975"; >> + compatible = "asahi-kasei,ak8975"; ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix 2015-01-09 4:36 ` [PATCH v5][resend v4] " Stephen Warren @ 2015-01-09 10:07 ` Kuninori Morimoto 2015-01-09 13:46 ` Rob Herring 0 siblings, 1 reply; 22+ messages in thread From: Kuninori Morimoto @ 2015-01-09 10:07 UTC (permalink / raw) To: linux-arm-kernel Hi Stephen Thank you for your feedback > > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during > > half-year (since Jun 2014) , many times. But, no-one care it. > > I don't know who is the best maintainer. > > - Stephen : because it has Tegra ? > > - Olof : because it has Tegra (= ARM) ? > > - Arnd : because it has Tegra (= ARM) ? > > - Matthias: because it has Tegra (= ARM SoC) ? > > - Rob : because DT ? > > - Andrew : Last chance ? > > > > But, could you please care this patch ? > > I will re-send it again > > It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively > changing a DT vendor name would need that, I think. Rob ? I had sent this patch to him since half-years ago, many times... Or other maintainer ? > Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it > seems they expect it to go through some tree other than Tegra. Weren't > there a bunch of related patches along with this (e.g. updating relevant > drivers to support both prefixes?) so it was expected this patch would > be applied together with them? I guess they expected it goes to DT branch (?) This is only 1 patch. it doesn't have related patch-set > >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> > >> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp > >> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) > >> > >> It went through the appropriate review process. But, almost all > >> Asahi Kasei chip drivers are using "asahi-kasei" prefix today. > >> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", > >> but there are instances of "asahi-kasei,ak8975" in other dts files. > >> And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) > >> So, we made a mistake there. > >> > >> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" > >> prerfix in DT file. > >> (DT compatible string vendor "asahi-kasei" appears un-documented) > >> > >> Marking it deprecated and warning with checkpatch is certainly > >> preferable. So, this patch replace "ak" to "asahi-kasei" in > >> vendor-prefixes.txt. (and fixup tegra20-seaboard) > >> > >> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch > >> doesn't care about it. Because no DT is using that today. > >> > >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> Acked-by: Thierry Reding <treding@nvidia.com> > >> Acked-by: Alexandre Courbot <acourbot@nvidia.com> > > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > > >> -ak Asahi Kasei Corp. > > >> +asahi-kasei Asahi Kasei Corp. > > >> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > > >> magnetometer at c { > >> - compatible = "ak,ak8975"; > >> + compatible = "asahi-kasei,ak8975"; > Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix 2015-01-09 10:07 ` Kuninori Morimoto @ 2015-01-09 13:46 ` Rob Herring 2015-01-09 13:55 ` Arnd Bergmann 0 siblings, 1 reply; 22+ messages in thread From: Rob Herring @ 2015-01-09 13:46 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 9, 2015 at 4:07 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > Hi Stephen > > Thank you for your feedback > >> > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during >> > half-year (since Jun 2014) , many times. But, no-one care it. >> > I don't know who is the best maintainer. >> > - Stephen : because it has Tegra ? >> > - Olof : because it has Tegra (= ARM) ? >> > - Arnd : because it has Tegra (= ARM) ? >> > - Matthias: because it has Tegra (= ARM SoC) ? >> > - Rob : because DT ? >> > - Andrew : Last chance ? >> > >> > But, could you please care this patch ? >> > I will re-send it again >> >> It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively >> changing a DT vendor name would need that, I think. > > Rob ? > I had sent this patch to him since half-years ago, many times... > Or other maintainer ? > >> Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it >> seems they expect it to go through some tree other than Tegra. Weren't >> there a bunch of related patches along with this (e.g. updating relevant >> drivers to support both prefixes?) so it was expected this patch would >> be applied together with them? > > I guess they expected it goes to DT branch (?) > This is only 1 patch. it doesn't have related patch-set It is in my queue. If the users of it are fine with breaking things, who am I to argue with them. Rob ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix 2015-01-09 13:46 ` Rob Herring @ 2015-01-09 13:55 ` Arnd Bergmann 2015-01-09 16:04 ` Mark Brown 0 siblings, 1 reply; 22+ messages in thread From: Arnd Bergmann @ 2015-01-09 13:55 UTC (permalink / raw) To: linux-arm-kernel On Friday 09 January 2015 07:46:16 Rob Herring wrote: > On Fri, Jan 9, 2015 at 4:07 AM, Kuninori Morimoto > <kuninori.morimoto.gx@renesas.com> wrote: > > > > Hi Stephen > > > > Thank you for your feedback > > > >> > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during > >> > half-year (since Jun 2014) , many times. But, no-one care it. > >> > I don't know who is the best maintainer. > >> > - Stephen : because it has Tegra ? > >> > - Olof : because it has Tegra (= ARM) ? > >> > - Arnd : because it has Tegra (= ARM) ? > >> > - Matthias: because it has Tegra (= ARM SoC) ? > >> > - Rob : because DT ? > >> > - Andrew : Last chance ? > >> > > >> > But, could you please care this patch ? > >> > I will re-send it again > >> > >> It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively > >> changing a DT vendor name would need that, I think. > > > > Rob ? > > I had sent this patch to him since half-years ago, many times... > > Or other maintainer ? > > > >> Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it > >> seems they expect it to go through some tree other than Tegra. Weren't > >> there a bunch of related patches along with this (e.g. updating relevant > >> drivers to support both prefixes?) so it was expected this patch would > >> be applied together with them? > > > > I guess they expected it goes to DT branch (?) > > This is only 1 patch. it doesn't have related patch-set > > It is in my queue. If the users of it are fine with breaking things, > who am I to argue with them. It's an i2c device, so it won't break, based on the implementation we use in the kernel that ignores the vendor part when the part number matches the i2c driver name. I also don't think we need to worry about any non-Linux operating systems on this board that might share the same dts file. Arnd ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix 2015-01-09 13:55 ` Arnd Bergmann @ 2015-01-09 16:04 ` Mark Brown 0 siblings, 0 replies; 22+ messages in thread From: Mark Brown @ 2015-01-09 16:04 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 09, 2015 at 02:55:40PM +0100, Arnd Bergmann wrote: > It's an i2c device, so it won't break, based on the implementation > we use in the kernel that ignores the vendor part when the part number > matches the i2c driver name. Plus this update is actually changing the board DT file have the ID which we've always had in the driver, the driver has always used the new string and never the ak, based one that the device tree is registering. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150109/0fb11c03/attachment.sig> ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5][resend v6] of: replace Asahi Kasei Corp vendor prefix 2014-12-02 4:57 ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto 2014-12-15 3:53 ` [PATCH v5][resend v2] " Kuninori Morimoto 2014-12-17 2:33 ` [PATCH v5][resend v3] " Kuninori Morimoto @ 2014-12-25 3:55 ` Kuninori Morimoto 2015-01-13 20:03 ` [PATCH v5][resend] " Rob Herring 3 siblings, 0 replies; 22+ messages in thread From: Kuninori Morimoto @ 2014-12-25 3:55 UTC (permalink / raw) To: linux-arm-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review process. But, almost all Asahi Kasei chip drivers are using "asahi-kasei" prefix today. (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", but there are instances of "asahi-kasei,ak8975" in other dts files. And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) So, we made a mistake there. In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" prerfix in DT file. (DT compatible string vendor "asahi-kasei" appears un-documented) Marking it deprecated and warning with checkpatch is certainly preferable. So, this patch replace "ak" to "asahi-kasei" in vendor-prefixes.txt. (and fixup tegra20-seaboard) OTOH, Asahi Kasei is usually referred to as "AKM", but this patch doesn't care about it. Because no DT is using that today. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Thierry Reding <treding@nvidia.com> Acked-by: Alexandre Courbot <acourbot@nvidia.com> --- >> Linus, Rob, Mark, Simon I resend this patch many times, but, there is still no response. Please, please check this patch, and give me some feedback. .../devicetree/bindings/vendor-prefixes.txt | 2 +- arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer at c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix 2014-12-02 4:57 ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto ` (2 preceding siblings ...) 2014-12-25 3:55 ` [PATCH v5][resend v6] " Kuninori Morimoto @ 2015-01-13 20:03 ` Rob Herring 3 siblings, 0 replies; 22+ messages in thread From: Rob Herring @ 2015-01-13 20:03 UTC (permalink / raw) To: linux-arm-kernel On Mon, Dec 1, 2014 at 10:57 PM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp > by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) > > It went through the appropriate review process. But, almost all > Asahi Kasei chip drivers are using "asahi-kasei" prefix today. > (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", > but there are instances of "asahi-kasei,ak8975" in other dts files. > And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) > So, we made a mistake there. > > In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" > prerfix in DT file. > (DT compatible string vendor "asahi-kasei" appears un-documented) > > Marking it deprecated and warning with checkpatch is certainly > preferable. So, this patch replace "ak" to "asahi-kasei" in > vendor-prefixes.txt. (and fixup tegra20-seaboard) > > OTOH, Asahi Kasei is usually referred to as "AKM", but this patch > doesn't care about it. Because no DT is using that today. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Thierry Reding <treding@nvidia.com> > Acked-by: Alexandre Courbot <acourbot@nvidia.com> Applied for 3.20. Thanks. > --- > v4 -> v5 > > - venter -> vendor on Subject > - fixup Acked-by ordering > > .../devicetree/bindings/vendor-prefixes.txt | 2 +- > arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 723999d..ddcb4cd 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -9,7 +9,6 @@ ad Avionic Design GmbH > adapteva Adapteva, Inc. > adi Analog Devices, Inc. > aeroflexgaisler Aeroflex Gaisler AB > -ak Asahi Kasei Corp. > allwinner Allwinner Technology Co., Ltd. > altr Altera Corp. > amcc Applied Micro Circuits Corporation (APM, formally AMCC) > @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. > apm Applied Micro Circuits Corporation (APM) > arm ARM Ltd. > armadeus ARMadeus Systems SARL > +asahi-kasei Asahi Kasei Corp. > atmel Atmel Corporation > auo AU Optronics Corporation > avago Avago Technologies > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > index a1d4bf9..7f5cf80 100644 > --- a/arch/arm/boot/dts/tegra20-seaboard.dts > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts > @@ -405,7 +405,7 @@ > clock-frequency = <400000>; > > magnetometer at c { > - compatible = "ak,ak8975"; > + compatible = "asahi-kasei,ak8975"; > reg = <0xc>; > interrupt-parent = <&gpio>; > interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; > -- > 1.7.9.5 > ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2015-01-13 20:03 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5398AB07.4040304@wwwdotorg.org>
[not found] ` <87sinbdk44.wl%kuninori.morimoto.gx@renesas.com>
[not found] ` <878ulzx6hr.wl%kuninori.morimoto.gx@gmail.com>
[not found] ` <20140922130026.GK3290@leverpostej>
[not found] ` <CAMuHMdX22z97SbGS1HDiYfJ1PXxyEN2S8D7w4sr+4bUwD+mJZw@mail.gmail.com>
[not found] ` <20140922132743.GM3290@leverpostej>
[not found] ` <87y4rfhmgl.wl%kuninori.morimoto.gx@renesas.com>
[not found] ` <1415845309.4269.6.camel@perches.com>
[not found] ` <20141113025105.GA16652@verge.net.au>
[not found] ` <87vbmjhj00.wl%kuninori.morimoto.gx@renesas.com>
[not found] ` <20141113110740.GE3815@sirena.org.uk>
2014-11-14 1:43 ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
2014-11-14 8:38 ` Alexandre Courbot
2014-11-14 9:16 ` Arnd Bergmann
2014-11-14 9:30 ` Thierry Reding
2014-11-14 9:35 ` [alsa-devel] " Thierry Reding
2014-11-17 0:51 ` [PATCH v4] " Kuninori Morimoto
2014-11-17 10:26 ` Sergei Shtylyov
2014-11-18 0:30 ` [PATCH v5] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
2014-11-28 0:22 ` [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
2014-11-28 11:45 ` Sergei Shtylyov
2014-12-02 4:57 ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
2014-12-15 3:53 ` [PATCH v5][resend v2] " Kuninori Morimoto
2014-12-17 2:33 ` [PATCH v5][resend v3] " Kuninori Morimoto
2015-01-09 3:40 ` [PATCH v5][resend v4] " Kuninori Morimoto
2015-01-09 3:42 ` [PATCH v5][resend v5] " Kuninori Morimoto
2015-01-09 4:36 ` [PATCH v5][resend v4] " Stephen Warren
2015-01-09 10:07 ` Kuninori Morimoto
2015-01-09 13:46 ` Rob Herring
2015-01-09 13:55 ` Arnd Bergmann
2015-01-09 16:04 ` Mark Brown
2014-12-25 3:55 ` [PATCH v5][resend v6] " Kuninori Morimoto
2015-01-13 20:03 ` [PATCH v5][resend] " Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).