* [PATCH] ARM: dts: DRA7: Add node for RTC
@ 2014-11-17 4:45 Lokesh Vutla
2014-11-17 12:17 ` Sergei Shtylyov
2014-11-19 12:23 ` [PATCH V2] " Lokesh Vutla
0 siblings, 2 replies; 8+ messages in thread
From: Lokesh Vutla @ 2014-11-17 4:45 UTC (permalink / raw)
To: linux-arm-kernel
Add node for RTC.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
[nm at ti.com: update with rtc crossbar number]
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 9cc9843..f98f9f0 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1075,6 +1075,15 @@
status = "disabled";
};
+ rtc: rtcss at 48838000 {
+ compatible = "ti,am3352-rtc";
+ reg = <0x48838000 0x100>;
+ interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
+ ti,hwmods = "rtcss";
+ clocks = <&sys_32k_ck>;
+ };
+
omap_control_usb2phy1: control-phy at 4a002300 {
compatible = "ti,control-phy-usb2";
reg = <0x4a002300 0x4>;
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] ARM: dts: DRA7: Add node for RTC
2014-11-17 4:45 [PATCH] ARM: dts: DRA7: Add node for RTC Lokesh Vutla
@ 2014-11-17 12:17 ` Sergei Shtylyov
2014-11-17 13:04 ` Lokesh Vutla
2014-11-19 12:23 ` [PATCH V2] " Lokesh Vutla
1 sibling, 1 reply; 8+ messages in thread
From: Sergei Shtylyov @ 2014-11-17 12:17 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11/17/2014 7:45 AM, Lokesh Vutla wrote:
> Add node for RTC.
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> [nm at ti.com: update with rtc crossbar number]
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 9cc9843..f98f9f0 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1075,6 +1075,15 @@
> status = "disabled";
> };
>
> + rtc: rtcss at 48838000 {
Please just name the node "rtc at 48838000", in accordance with ePAPR.
> + compatible = "ti,am3352-rtc";
> + reg = <0x48838000 0x100>;
> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
2 similar interrupts?
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: dts: DRA7: Add node for RTC
2014-11-17 12:17 ` Sergei Shtylyov
@ 2014-11-17 13:04 ` Lokesh Vutla
2014-11-17 16:12 ` Sergei Shtylyov
0 siblings, 1 reply; 8+ messages in thread
From: Lokesh Vutla @ 2014-11-17 13:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Monday 17 November 2014 05:47 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 11/17/2014 7:45 AM, Lokesh Vutla wrote:
>
>> Add node for RTC.
>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>> [nm at ti.com: update with rtc crossbar number]
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 9cc9843..f98f9f0 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -1075,6 +1075,15 @@
>> status = "disabled";
>> };
>>
>> + rtc: rtcss at 48838000 {
>
> Please just name the node "rtc at 48838000", in accordance with ePAPR.
Okay. will update it.
>
>> + compatible = "ti,am3352-rtc";
>> + reg = <0x48838000 0x100>;
>> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
>
> 2 similar interrupts?
both rtc timer and rtc alarm uses same interrupt on DRA7 Soc.
Driver handles it accordingly.
So passing the same interrupt.
Thanks and regards,
Lokesh
>
> [...]
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: dts: DRA7: Add node for RTC
2014-11-17 13:04 ` Lokesh Vutla
@ 2014-11-17 16:12 ` Sergei Shtylyov
2014-11-18 5:01 ` Lokesh Vutla
0 siblings, 1 reply; 8+ messages in thread
From: Sergei Shtylyov @ 2014-11-17 16:12 UTC (permalink / raw)
To: linux-arm-kernel
On 11/17/2014 4:04 PM, Lokesh Vutla wrote:
>> On 11/17/2014 7:45 AM, Lokesh Vutla wrote:
>>> Add node for RTC.
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> [nm at ti.com: update with rtc crossbar number]
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> ---
>>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>>> index 9cc9843..f98f9f0 100644
>>> --- a/arch/arm/boot/dts/dra7.dtsi
>>> +++ b/arch/arm/boot/dts/dra7.dtsi
>>> @@ -1075,6 +1075,15 @@
>>> status = "disabled";
>>> };
>>>
>>> + rtc: rtcss at 48838000 {
>> Please just name the node "rtc at 48838000", in accordance with ePAPR.
> Okay. will update it.
>>> + compatible = "ti,am3352-rtc";
>>> + reg = <0x48838000 0x100>;
>>> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
>> 2 similar interrupts?
> both rtc timer and rtc alarm uses same interrupt on DRA7 Soc.
> Driver handles it accordingly.
> So passing the same interrupt.
I think it would have been better if the driver just handled a single
interrupt.
> Thanks and regards,
> Lokesh
>> [...]
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: dts: DRA7: Add node for RTC
2014-11-17 16:12 ` Sergei Shtylyov
@ 2014-11-18 5:01 ` Lokesh Vutla
2014-11-18 10:55 ` Sergei Shtylyov
0 siblings, 1 reply; 8+ messages in thread
From: Lokesh Vutla @ 2014-11-18 5:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Monday 17 November 2014 09:42 PM, Sergei Shtylyov wrote:
> On 11/17/2014 4:04 PM, Lokesh Vutla wrote:
>
>>> On 11/17/2014 7:45 AM, Lokesh Vutla wrote:
>
>>>> Add node for RTC.
>
>>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>>> [nm at ti.com: update with rtc crossbar number]
>>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>>> ---
>>>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
>>>> 1 file changed, 9 insertions(+)
>
>>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>>>> index 9cc9843..f98f9f0 100644
>>>> --- a/arch/arm/boot/dts/dra7.dtsi
>>>> +++ b/arch/arm/boot/dts/dra7.dtsi
>>>> @@ -1075,6 +1075,15 @@
>>>> status = "disabled";
>>>> };
>>>>
>>>> + rtc: rtcss at 48838000 {
>
>>> Please just name the node "rtc at 48838000", in accordance with ePAPR.
>
>> Okay. will update it.
>
>>>> + compatible = "ti,am3352-rtc";
>>>> + reg = <0x48838000 0x100>;
>>>> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>>>> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
>
>>> 2 similar interrupts?
>
>> both rtc timer and rtc alarm uses same interrupt on DRA7 Soc.
>> Driver handles it accordingly.
>> So passing the same interrupt.
>
> I think it would have been better if the driver just handled a single interrupt.
There are certain SoCs with RTC IP where timer and alarm uses different interrupts.
Driver has to take care of that scenario also. So it expects two interrupts from dt.
Thanks and regards,
Lokesh
>
>> Thanks and regards,
>> Lokesh
>
>>> [...]
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: dts: DRA7: Add node for RTC
2014-11-18 5:01 ` Lokesh Vutla
@ 2014-11-18 10:55 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2014-11-18 10:55 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11/18/2014 8:01 AM, Lokesh Vutla wrote:
>>>>> Add node for RTC.
>>>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>>>> [nm at ti.com: update with rtc crossbar number]
>>>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>>>> ---
>>>>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
>>>>> 1 file changed, 9 insertions(+)
>>>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>>>>> index 9cc9843..f98f9f0 100644
>>>>> --- a/arch/arm/boot/dts/dra7.dtsi
>>>>> +++ b/arch/arm/boot/dts/dra7.dtsi
>>>>> @@ -1075,6 +1075,15 @@
>>>>> status = "disabled";
>>>>> };
>>>>>
>>>>> + rtc: rtcss at 48838000 {
>>>> Please just name the node "rtc at 48838000", in accordance with ePAPR.
>>> Okay. will update it.
>>>>> + compatible = "ti,am3352-rtc";
>>>>> + reg = <0x48838000 0x100>;
>>>>> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
>>>> 2 similar interrupts?
>>> both rtc timer and rtc alarm uses same interrupt on DRA7 Soc.
>>> Driver handles it accordingly.
>>> So passing the same interrupt.
>> I think it would have been better if the driver just handled a single interrupt.
> There are certain SoCs with RTC IP where timer and alarm uses different interrupts.
I understood.
> Driver has to take care of that scenario also. So it expects two interrupts from dt.
You could also handle the missing second interrupt. I don't insist though...
> Thanks and regards,
> Lokesh
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2] ARM: dts: DRA7: Add node for RTC
2014-11-17 4:45 [PATCH] ARM: dts: DRA7: Add node for RTC Lokesh Vutla
2014-11-17 12:17 ` Sergei Shtylyov
@ 2014-11-19 12:23 ` Lokesh Vutla
2014-11-22 0:00 ` Tony Lindgren
1 sibling, 1 reply; 8+ messages in thread
From: Lokesh Vutla @ 2014-11-19 12:23 UTC (permalink / raw)
To: linux-arm-kernel
Add node for RTC.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
[nm at ti.com: update with rtc crossbar number]
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Changes since v1:
- Fixed rtc dt node label.
arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 9cc9843..5d92562 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1075,6 +1075,15 @@
status = "disabled";
};
+ rtc at 48838000 {
+ compatible = "ti,am3352-rtc";
+ reg = <0x48838000 0x100>;
+ interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
+ ti,hwmods = "rtcss";
+ clocks = <&sys_32k_ck>;
+ };
+
omap_control_usb2phy1: control-phy at 4a002300 {
compatible = "ti,control-phy-usb2";
reg = <0x4a002300 0x4>;
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH V2] ARM: dts: DRA7: Add node for RTC
2014-11-19 12:23 ` [PATCH V2] " Lokesh Vutla
@ 2014-11-22 0:00 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2014-11-22 0:00 UTC (permalink / raw)
To: linux-arm-kernel
* Lokesh Vutla <lokeshvutla@ti.com> [141119 04:26]:
> Add node for RTC.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> [nm at ti.com: update with rtc crossbar number]
> Signed-off-by: Nishanth Menon <nm@ti.com>
Applying into omap-for-v3.19/dt-v2 thanks.
Tony
> ---
> Changes since v1:
> - Fixed rtc dt node label.
> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 9cc9843..5d92562 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1075,6 +1075,15 @@
> status = "disabled";
> };
>
> + rtc at 48838000 {
> + compatible = "ti,am3352-rtc";
> + reg = <0x48838000 0x100>;
> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
> + ti,hwmods = "rtcss";
> + clocks = <&sys_32k_ck>;
> + };
> +
> omap_control_usb2phy1: control-phy at 4a002300 {
> compatible = "ti,control-phy-usb2";
> reg = <0x4a002300 0x4>;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-11-22 0:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17 4:45 [PATCH] ARM: dts: DRA7: Add node for RTC Lokesh Vutla
2014-11-17 12:17 ` Sergei Shtylyov
2014-11-17 13:04 ` Lokesh Vutla
2014-11-17 16:12 ` Sergei Shtylyov
2014-11-18 5:01 ` Lokesh Vutla
2014-11-18 10:55 ` Sergei Shtylyov
2014-11-19 12:23 ` [PATCH V2] " Lokesh Vutla
2014-11-22 0:00 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).