From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Tue, 18 Nov 2014 21:51:25 +0800 Subject: [PATCH v5 03/18] ACPI / table: Count matched and successfully parsed entries without specifying max entries In-Reply-To: <1413553034-20956-4-git-send-email-hanjun.guo@linaro.org> References: <1413553034-20956-1-git-send-email-hanjun.guo@linaro.org> <1413553034-20956-4-git-send-email-hanjun.guo@linaro.org> Message-ID: <546B4EDD.9050804@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rafael, On 2014?10?17? 21:36, Hanjun Guo wrote: > From: Tomasz Nowicki > > It is very useful to traverse all available table entries without max > number of expected entries type. Current acpi_parse_entries() > implementation gives that feature but it does not count those entries, > it returns 0 instead, so fix it to count matched and successfully > entries and return it. > > NOTE: This change has no impact to x86 and ia64 archs since existing code > checks for error occurrence only (acpi_parse_entries(...,0) < 0). > > Acked-by: Grant Likely > Signed-off-by: Tomasz Nowicki > Signed-off-by: Hanjun Guo Patch 2 and patch 3 are only for ACPI cores, and have no harm to x86 and IA64, could you merge first in 3.19? Thanks Hanjun > --- > drivers/acpi/tables.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index 21ae521..b18e45e 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -225,10 +225,13 @@ acpi_parse_entries(unsigned long table_size, > while (((unsigned long)entry) + sizeof(struct acpi_subtable_header) < > table_end) { > if (entry->type == entry_id > - && (!max_entries || count++ < max_entries)) > + && (!max_entries || count < max_entries)) { > if (handler(entry, table_end)) > return -EINVAL; > > + count++; > + } > + > /* > * If entry->length is 0, break from this loop to avoid > * infinite loop. >