From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller
Date: Wed, 19 Nov 2014 16:49:53 +0900 [thread overview]
Message-ID: <546C4BA1.6090701@samsung.com> (raw)
In-Reply-To: <1416337853-1558-1-git-send-email-tyler.baker@linaro.org>
On 11/19/14 04:10, Tyler Baker wrote:
Hi,
+ Arnd, Olof and Kevin
> This patch fixes a long standing issue introduced during the 3.16 merge window.
> Shortly after the merge, exynos5250-based arndale boards began to produce the
> following errors:
>
> kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage
> kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22
>
> Further analysis revealed that the S5M8767 voltage regulator used on the
> exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the
> S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator
> fails to probe. Therefore a dependency exists between these two drivers.
> In the exynos_defconfig both CONFIG_REGULATOR_S5M8767 and CONFIG_I2C_S3C2410
> options are enabled, and no errors are produced. However, in the
> multi_v7_defconfig only the CONFIG_REGULATOR_S5M8767 option is enabled and the
> errors are present. So let's enable the CONFIG_I2C_S3C2410 option in the
> multi_v7_defconfig to allow the S5M8767 voltage regulator to probe.
>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks,
Kukjin
> ---
> This issue was reported [1]. I've also confirmed this fix on two different
> arndale boards.
>
> [1] https://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg38765.html
>
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 3487046..9d7a32f 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -217,6 +217,7 @@ CONFIG_I2C_CADENCE=y
> CONFIG_I2C_DESIGNWARE_PLATFORM=y
> CONFIG_I2C_EXYNOS5=y
> CONFIG_I2C_MV64XXX=y
> +CONFIG_I2C_S3C2410=y
> CONFIG_I2C_SIRF=y
> CONFIG_I2C_TEGRA=y
> CONFIG_I2C_ST=y
next prev parent reply other threads:[~2014-11-19 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 19:10 [PATCH] ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller Tyler Baker
2014-11-19 7:49 ` Kukjin Kim [this message]
2014-11-19 17:40 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546C4BA1.6090701@samsung.com \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).