From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 692B3C77B7E for ; Tue, 2 May 2023 08:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t548MO19BncyWwYir4OybDPtbBVXnEOPLZSB5R2ZWGg=; b=Ck4JApfk2JqUVp RMFzJLVcO0icpfWwZdyI3Pfwv8uprIsFsR6/jwJDOhkgHBFEj+I69pz2kOM+srV0V894qqBK1Up9V VHhMOJ38QFj8etW3uppvfrKVNQnxL5s8CtFsrFnwfS/vpRENfbd7gDQ3x2fhqoxXRKHTLTd2wynnT t92SNUVkoHAOG+W9C95WFp58KrJn9qhfH2d7T+8MaJ+kU81Ps1mRdglnYL4cV/vB5dUmsLaHnT7nj h9ldB6M1/lOOEvu3rbO9gtfs0g4LpJmD6SXpmesWmwoWHuTTD/7MgaB34W7txp+AYHjLT1RxKFEXT 79qr65aF/NZktoabmDbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ptlb9-000eq8-0V; Tue, 02 May 2023 08:42:59 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ptlb4-000eoU-1b; Tue, 02 May 2023 08:42:57 +0000 Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ptlay-0006Md-K6; Tue, 02 May 2023 10:42:48 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Sebastian Reichel , Shreeya Patel , Kever Yang , Finley Xiao , Cristian Ciocaltea Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 2/8] dt-bindings: nvmem: rockchip-otp: Add compatible for RK3588 Date: Tue, 02 May 2023 10:42:47 +0200 Message-ID: <5471965.k3LOHGUjKi@diego> In-Reply-To: <20230501084401.765169-3-cristian.ciocaltea@collabora.com> References: <20230501084401.765169-1-cristian.ciocaltea@collabora.com> <20230501084401.765169-3-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230502_014254_532791_0CC8A3D8 X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Montag, 1. Mai 2023, 10:43:54 CEST schrieb Cristian Ciocaltea: > Document the OTP memory found on Rockchip RK3588 SoC. nit: I guess the changed clock and resets configuration for rk3588 variants could be mentioned in the commit message. Reviewed-by: Heiko Stuebner > Signed-off-by: Cristian Ciocaltea > --- > .../bindings/nvmem/rockchip-otp.yaml | 71 ++++++++++++++++--- > 1 file changed, 60 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml > index 658ceed14ee2..84a11382c6e7 100644 > --- a/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml > +++ b/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml > @@ -9,34 +9,31 @@ title: Rockchip internal OTP (One Time Programmable) memory > maintainers: > - Heiko Stuebner > > -allOf: > - - $ref: nvmem.yaml# > - > properties: > compatible: > enum: > - rockchip,px30-otp > - rockchip,rk3308-otp > + - rockchip,rk3588-otp > > reg: > maxItems: 1 > > clocks: > minItems: 3 > - maxItems: 3 > + maxItems: 4 > > clock-names: > - items: > - - const: otp > - - const: apb_pclk > - - const: phy > + minItems: 3 > + maxItems: 4 > > resets: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > > reset-names: > - items: > - - const: phy > + minItems: 1 > + maxItems: 3 > > required: > - compatible > @@ -46,6 +43,58 @@ required: > - resets > - reset-names > > +allOf: > + - $ref: nvmem.yaml# > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,px30-otp > + - rockchip,rk3308-otp > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 > + clock-names: > + items: > + - const: otp > + - const: apb_pclk > + - const: phy > + resets: > + maxItems: 1 > + reset-names: > + items: > + - const: phy > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3588-otp > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 > + clock-names: > + items: > + - const: otpc > + - const: apb > + - const: arb > + - const: phy > + resets: > + minItems: 1 > + maxItems: 3 > + reset-names: > + items: > + - const: otpc > + - const: apb > + - const: arb > + > unevaluatedProperties: false > > examples: > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel