From: petr.cvek@tul.cz (Petr Cvek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Fix PXA2xx RTC, interrupts before register ioremap
Date: Mon, 24 Nov 2014 05:31:59 +0100 [thread overview]
Message-ID: <5472B4BF.3020300@tul.cz> (raw)
Fix commits:
a44802f8fb7e593adabc6ef53c8df45a1717fa9b drivers/rtc/rtc-pxa.c: fix alarm can't wake up system issue
2f6e5f9458646263d3d9ffadd5e11e3d8d15a7d0 drivers/rtc: remove IRQF_DISABLED
Interrupts appear before registers of the RTC controller are ioremapped.
Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
---
drivers/rtc/rtc-pxa.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index 4561f37..d7d83e5 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
@@ -346,7 +346,7 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
dev_err(dev, "No alarm IRQ resource defined\n");
return -ENXIO;
}
- pxa_rtc_open(dev);
+
pxa_rtc->base = devm_ioremap(dev, pxa_rtc->ress->start,
resource_size(pxa_rtc->ress));
if (!pxa_rtc->base) {
@@ -375,6 +375,10 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
return ret;
}
+ ret = pxa_rtc_open(dev);
+ if (ret)
+ return ret;
+
device_init_wakeup(dev, 1);
return 0;
--
1.7.12.1
reply other threads:[~2014-11-24 4:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5472B4BF.3020300@tul.cz \
--to=petr.cvek@tul.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).