linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: xerofoify@gmail.com (nick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c
Date: Mon, 24 Nov 2014 14:36:11 -0500	[thread overview]
Message-ID: <547388AB.9050103@gmail.com> (raw)
In-Reply-To: <08ea34761ecd4d5a8bc814d1d42c9b61@BN1AFFO11FD048.protection.gbl>

Soren,
If you want me to change it I would be glad, I wasn't sure what to write to be honest but if you have
a better message in mind please let me known.
Cheers Nick 

On 14-11-24 02:33 PM, S?ren Brinkmann wrote:
> On Mon, 2014-11-24 at 08:31PM +0100, Michal Simek wrote:
>> On 11/24/2014 08:25 PM, Nicholas Krause wrote:
>>> Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH
>>> due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits
>>> of the bus width and not just the lower or higher 16 depending on the machine's bit
>>> order.
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>>  drivers/block/xsysace.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
>>> index c4328d9..1b807ed 100644
>>> --- a/drivers/block/xsysace.c
>>> +++ b/drivers/block/xsysace.c
>>> @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)
>>>  static int ace_probe(struct platform_device *dev)
>>>  {
>>>  	resource_size_t physaddr = 0;
>>> -	int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
>>> +	int bus_width = ACE_BUS_WIDTH_16;
>>>  	u32 id = dev->id;
>>>  	int irq = 0;
>>>  	int i;
>>>
>>
>> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
> 
> I find the commit message rather misleading, but the change is OK.
> 
> 	S?ren
> 

      reply	other threads:[~2014-11-24 19:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 19:25 [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c Nicholas Krause
2014-11-24 19:31 ` Michal Simek
2014-11-24 19:33   ` Sören Brinkmann
2014-11-24 19:36     ` nick [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547388AB.9050103@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).