* [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c
@ 2014-11-24 19:25 Nicholas Krause
2014-11-24 19:31 ` Michal Simek
0 siblings, 1 reply; 4+ messages in thread
From: Nicholas Krause @ 2014-11-24 19:25 UTC (permalink / raw)
To: linux-arm-kernel
Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH
due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits
of the bus width and not just the lower or higher 16 depending on the machine's bit
order.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/block/xsysace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
index c4328d9..1b807ed 100644
--- a/drivers/block/xsysace.c
+++ b/drivers/block/xsysace.c
@@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)
static int ace_probe(struct platform_device *dev)
{
resource_size_t physaddr = 0;
- int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
+ int bus_width = ACE_BUS_WIDTH_16;
u32 id = dev->id;
int irq = 0;
int i;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c
2014-11-24 19:25 [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c Nicholas Krause
@ 2014-11-24 19:31 ` Michal Simek
2014-11-24 19:33 ` Sören Brinkmann
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2014-11-24 19:31 UTC (permalink / raw)
To: linux-arm-kernel
On 11/24/2014 08:25 PM, Nicholas Krause wrote:
> Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH
> due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits
> of the bus width and not just the lower or higher 16 depending on the machine's bit
> order.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/block/xsysace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
> index c4328d9..1b807ed 100644
> --- a/drivers/block/xsysace.c
> +++ b/drivers/block/xsysace.c
> @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)
> static int ace_probe(struct platform_device *dev)
> {
> resource_size_t physaddr = 0;
> - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
> + int bus_width = ACE_BUS_WIDTH_16;
> u32 id = dev->id;
> int irq = 0;
> int i;
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c
2014-11-24 19:31 ` Michal Simek
@ 2014-11-24 19:33 ` Sören Brinkmann
2014-11-24 19:36 ` nick
0 siblings, 1 reply; 4+ messages in thread
From: Sören Brinkmann @ 2014-11-24 19:33 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2014-11-24 at 08:31PM +0100, Michal Simek wrote:
> On 11/24/2014 08:25 PM, Nicholas Krause wrote:
> > Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH
> > due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits
> > of the bus width and not just the lower or higher 16 depending on the machine's bit
> > order.
> >
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> > ---
> > drivers/block/xsysace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
> > index c4328d9..1b807ed 100644
> > --- a/drivers/block/xsysace.c
> > +++ b/drivers/block/xsysace.c
> > @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)
> > static int ace_probe(struct platform_device *dev)
> > {
> > resource_size_t physaddr = 0;
> > - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
> > + int bus_width = ACE_BUS_WIDTH_16;
> > u32 id = dev->id;
> > int irq = 0;
> > int i;
> >
>
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
I find the commit message rather misleading, but the change is OK.
S?ren
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c
2014-11-24 19:33 ` Sören Brinkmann
@ 2014-11-24 19:36 ` nick
0 siblings, 0 replies; 4+ messages in thread
From: nick @ 2014-11-24 19:36 UTC (permalink / raw)
To: linux-arm-kernel
Soren,
If you want me to change it I would be glad, I wasn't sure what to write to be honest but if you have
a better message in mind please let me known.
Cheers Nick
On 14-11-24 02:33 PM, S?ren Brinkmann wrote:
> On Mon, 2014-11-24 at 08:31PM +0100, Michal Simek wrote:
>> On 11/24/2014 08:25 PM, Nicholas Krause wrote:
>>> Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH
>>> due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits
>>> of the bus width and not just the lower or higher 16 depending on the machine's bit
>>> order.
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>> drivers/block/xsysace.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
>>> index c4328d9..1b807ed 100644
>>> --- a/drivers/block/xsysace.c
>>> +++ b/drivers/block/xsysace.c
>>> @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)
>>> static int ace_probe(struct platform_device *dev)
>>> {
>>> resource_size_t physaddr = 0;
>>> - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
>>> + int bus_width = ACE_BUS_WIDTH_16;
>>> u32 id = dev->id;
>>> int irq = 0;
>>> int i;
>>>
>>
>> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
>
> I find the commit message rather misleading, but the change is OK.
>
> S?ren
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-24 19:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 19:25 [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c Nicholas Krause
2014-11-24 19:31 ` Michal Simek
2014-11-24 19:33 ` Sören Brinkmann
2014-11-24 19:36 ` nick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).