From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Tue, 25 Nov 2014 08:35:21 +0100 Subject: [RFC PATCH v4 0/8] Introduce automatic DMA configuration for IOMMU masters In-Reply-To: <20141119114150.GD15985@arm.com> References: <1415991397-9618-1-git-send-email-will.deacon@arm.com> <546C7D36.7030400@samsung.com> <20141119114150.GD15985@arm.com> Message-ID: <54743139.2020804@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On 2014-11-19 12:41, Will Deacon wrote: > Hi Marek, > > On Wed, Nov 19, 2014 at 11:21:26AM +0000, Marek Szyprowski wrote: >> On 2014-11-14 19:56, Will Deacon wrote: >>> Hello everybody, >>> >>> Here is the fourth iteration of the RFC I've previously posted here: >>> >>> RFCv1: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/283023.html >>> RFCv2: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/283752.html >>> RFCv3: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/287031.html >>> >>> Changes since RFCv3 include: >>> >>> - Drastic simplification of the data structures, so that we no longer >>> pass around lists of domains. Instead, dma-mapping is expected to >>> allocate the domain (Joerg talked about adding a get_default_domain >>> operation to iommu_ops). >>> >>> - iommu_ops is used to hold the per-instance IOMMU data >>> >>> - Configuration of DMA segments added to of_dma_configure >>> >>> All feedback welcome. >> I've rebased my Exynos SYSMMU patches on top of this patchset and it >> works fine, >> You can find them in the "[PATCH v3 00/19] Exynos SYSMMU (IOMMU) >> integration with DT >> and DMA-mapping subsystem" thread. > I just saw that and it looks great, thanks! FWIW, I'll take the first 3 > patches you have into my series in some shape or another. It would be great if the iommu integration patches were merged to -next to give them a try for a few days. Joerg: do you plan to take those patches to v3.19 or do you want to wait more? >> You can add to all your patches: >> Acked-by: Marek Szyprowski > Cheers. > >> I'm also interested in adding get_default_domain() callback, but I >> assume that this >> can be done once the basic patchset get merged. Do you plan to work on >> it, do you want >> me to implement it? > If Joerg isn't working on it already (I don't think he is), then please > do have a go if you have time. You'll probably want to avoid adding devices > with addressing restrictions (i.e. non-zero dma_pfn_offset, weird dma masks) > to the default domain, otherwise you'll run into issues initialising the > iova allocator. > > I had a go at getting ARM dma-mapping to use a hypothetical > get_default_domain function, so I've included the diff I ended up with below, > in case it's at all useful. I will check that soon, but I hope this is not strictly needed to get basic iommu and dma-mapping integration merged. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland