From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/2] Reworked rk3288-tinker-s devicetree
Date: Wed, 26 Sep 2018 14:32:10 +0200 [thread overview]
Message-ID: <5476375.mdEj9W728V@phil> (raw)
In-Reply-To: <20180923113807.11558-1-heiko@sntech.de>
Am Sonntag, 23. September 2018, 13:38:05 CEST schrieb Heiko Stuebner:
> Hi David,
>
> I've adpated your patches 1+2 like so and would like to add them this way
> later on. Biggest change is of course making patch 1 solely about moving
> the shared parts to the dtsi and adding the tinker-s.dts including the
> emmc in the second patch.
>
> Apart from that you can also see some previously missing style-related
> fixes. For example patch subject lines are somewhat specific, to allow
> people browsing the git history to realize the core patch contents just
> from the "headline" and also use the "correct" prefixes which vary
> depending on the subsystem your changing.
>
> For future patches you can just do a "git log --oneline arch/arm/boot/dts"
> (change directory depending on location of the change of course), to
> see that arm32 dts use "ARM: dts: $soc-vendor: foo".
>
>
> Also providing a commit message describing the individual change
> in a bit more detail is important.
>
> The wifi patch is a different issue, so I'll reply there.
>
>
> Heiko
>
> David Summers (2):
> ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
> ARM: dts: rockchip: add rk3288-based Tinker board S
applied for 4.20
prev parent reply other threads:[~2018-09-26 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 11:38 [PATCH v4 0/2] Reworked rk3288-tinker-s devicetree Heiko Stuebner
2018-09-23 11:38 ` [PATCH v4 1/2] ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi Heiko Stuebner
2018-09-23 11:38 ` [PATCH v4 2/2] ARM: dts: rockchip: add rk3288-based Tinker board S Heiko Stuebner
2018-09-27 18:24 ` Rob Herring
2018-09-23 16:44 ` [PATCH v4 0/2] Reworked rk3288-tinker-s devicetree David Summers
2018-09-26 12:32 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5476375.mdEj9W728V@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox