linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos_defconfig: disable CONFIG_EXYNOS5420_MCPM; not stable
Date: Thu, 27 Nov 2014 18:57:03 +0000	[thread overview]
Message-ID: <547773FF.9000205@arm.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1411261314310.11690@knanqh.ubzr>



On 26/11/14 18:41, Nicolas Pitre wrote:
> On Wed, 26 Nov 2014, Kevin Hilman wrote:
>
>> Abhilash Kesavan <kesavan.abhilash@gmail.com> writes:
>>
>>> Hi Kevin,
>>>
>>> On Wed, Nov 26, 2014 at 6:30 AM, Kevin Hilman <khilman@kernel.org> wrote:
>>>> [...]
>>>>
>>>> More specifically, with only the loopback call to turn off CCI commented
>>>> out, the imprecise aborts go away.
>>>
>>> I can't see how enabling snoops for the boot cluster is causing these
>>> aborts. Perhaps as Krzysztof commented it has something to do with the
>>> secure firmware/tz software on these boards ? Other than there does
>>> not appear to be any difference between the working/non-working
>>> setups.
>>
>> Perhaps the secure firmware is preventing the CCI to be enabled by the
>> kernel, and that is causing the imprecise abort?
>
> That is well possible.
>
> Now...... if the bootloader/firmware does not let Linux deal with both
> the CCI and caches then MCPM simply has no more purpose for this board.
> The whole point of MCPM is actually to handle the CCI properly and the
> most efficient way despite all the possible races and opportunities for
> memory corruptions. And yes, this is a complex task.
>
> So there is actually two choices: the firmware let Linux take care of it
> via the MCPM layer (easy), or the firmware has to implement it all
> _properly_ (hard) behind an interface such as PSCI, at which point MCPM
> should be configured out.
>
> If the firmware does not let Linux interact with the CCI _and_ does not
> implement full MCPM-like services then the platform is broken and only a
> firmware upgrade could fix that.  It might still be possible to boot all
> CPUs through other means, but power management would then be severely
> limited.
>

Thanks Nico for the detailed description on the requirements for using
MCPM. This is the kind of issue I was worried in the other thread on
Fijitsu platform. That's the reason I was asking the information about
their secure firmware and what exactly it configures so that we won't
end up with similar situation on there too and definitely not to push
PSCI. I completely agree with you that making a some change in firmware
to give control of CCI to kernel is easy.

Probably if the vendors disagree to apply this small fix to the firmware
we should provide them with *only choice* of PSCI implementation which
is quite complex and easy to get it wrong. That might trigger them to
provide a small fix to use MCPM.

Regards,
Sudeep

  parent reply	other threads:[~2014-11-27 18:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31 22:59 [PATCH] ARM: exynos_defconfig: disable CONFIG_EXYNOS5420_MCPM; not stable Kevin Hilman
2014-11-08  9:50 ` Kukjin Kim
2014-11-10 19:35   ` Kevin Hilman
2014-11-24 19:51     ` Kevin Hilman
2014-11-25  0:25       ` Olof Johansson
2014-11-25  1:35         ` Kevin Hilman
2014-11-25  1:37           ` Olof Johansson
2014-11-25  1:38             ` Olof Johansson
2014-11-25  1:50               ` Kukjin Kim
2014-11-25  3:20                 ` Kevin Hilman
2014-11-25  6:01                   ` Abhilash Kesavan
2014-11-26  1:00                     ` Kevin Hilman
2014-11-26 16:58                       ` Abhilash Kesavan
2014-11-26 17:56                         ` Kevin Hilman
2014-11-26 18:11                           ` Kukjin Kim
2014-11-26 18:41                           ` Nicolas Pitre
2014-11-27 16:51                             ` Abhilash Kesavan
2014-11-27 17:06                               ` Nicolas Pitre
2014-11-28 14:41                                 ` Abhilash Kesavan
2014-11-27 18:57                             ` Sudeep Holla [this message]
2014-11-25  8:47                   ` Krzysztof Kozlowski
2014-11-25  9:07                     ` Krzysztof Kozlowski
2014-11-25  2:13             ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547773FF.9000205@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).