From: gang.chen.5i5j@gmail.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] kvm: arm: vgic: Let one looping code instead of two looping code
Date: Mon, 01 Dec 2014 22:04:32 +0800 [thread overview]
Message-ID: <547C7570.1020006@gmail.com> (raw)
In-Reply-To: <20141130100718.GA484@cbox>
On 11/30/2014 06:07 PM, Christoffer Dall wrote:
> On Sun, Nov 30, 2014 at 12:18:04PM +0800, Chen Gang wrote:
>> Use one looping instead of two, so can let code more simpler and get a
>> little better performance.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
> Performance? Please, this is vgic_create....
>
I guess your meaning is "this code is not performance sensitive", do not
mean "1 looping can not get a little better performance than 2 looping".
If what I guess is incorrect, please let me know.
> This does nothing else than introduce churn.
>
I don't think it does nothing, it can let code simpler than before:
remove the redundant looping -- the 2 looping do the same thing which
is commented just above the firstly looping.
And I don't know which churn this patch will introduce. At least, no one
want to waste him/her time resources to intend churn, please provide
more details about it.
If kvm does not like me, or does not like members to find issues based
on reading source code, please let me know (no reply means kvm does not
like me or this way), I will quit, so can save time resources both.
Thanks.
--
Chen Gang
Open share and attitude like air water and life which God blessed
next prev parent reply other threads:[~2014-12-01 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 4:18 [PATCH] kvm: arm: vgic: Let one looping code instead of two looping code Chen Gang
2014-11-30 10:07 ` Christoffer Dall
2014-12-01 14:04 ` Chen Gang [this message]
2014-11-30 11:08 ` Christoffer Dall
2014-11-30 14:21 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C7570.1020006@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).