linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andrew.Jackson@arm.com (Andrew Jackson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ASoC: dwc: Add devicetree support for Designware I2S
Date: Thu, 04 Dec 2014 09:43:57 +0000	[thread overview]
Message-ID: <54802CDD.6080000@arm.com> (raw)
In-Reply-To: <2041200.ZjakFFAZAU@wuerfel>

On 12/03/14 20:13, Arnd Bergmann wrote:
> On Wednesday 03 December 2014 16:39:08 Andrew Jackson wrote:
>> Convert to driver to use either platform_data or device-tree for configuration
>> of the device.  When using device-tree, the I2S block's configuration is read
>> from the relevant registers: this reduces the amount of information required in
>> the device tree.
>>
>> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
> 
> I don't think we even have to worry about the platform_data case here:
> the only platform using this hardware in Linux is arm/mach-spear, and
> it defines a device node with a binding that is similar to the one you
> document here but that is not implemented in the driver.
> 
> So, I think for all practical purposes we can assume that nobody cares
> if you make incompatible changes as long as you don't introduce build
> regression.
> 
> Also, please adapt the 	arch/arm/boot/dts/spear13*.dts{,i} files
> as good as you can. They are broken in other ways too that you don't
> have to fix, just make them conform to the binding you add.
> 

Will do.  Although I had noticed those DT entries, I couldn't find anything in support of them.  I wasn't sure whether someone else was waiting in the wings (so as to speak) with a DT enabled Designware I2S driver. 

> 	Arnd
> 
> 

  parent reply	other threads:[~2014-12-04  9:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 16:39 [PATCH 4/5] ASoC: dwc: Add devicetree support for Designware I2S Andrew Jackson
2014-12-03 18:23 ` Mark Brown
2014-12-04  9:42   ` Andrew Jackson
2014-12-03 20:13 ` Arnd Bergmann
2014-12-03 20:19   ` Mark Brown
2014-12-04  9:55     ` Arnd Bergmann
2014-12-04 11:07       ` Mark Brown
2014-12-04 11:17         ` Arnd Bergmann
2014-12-04 11:33           ` Mark Brown
2014-12-04  9:43   ` Andrew Jackson [this message]
2014-12-04  7:02 ` rajeev kumar
2014-12-04  7:43 ` rajeev kumar
2014-12-04 10:00   ` Andrew Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54802CDD.6080000@arm.com \
    --to=andrew.jackson@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).