From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm: fix __iomem annotation on kona_smc
Date: Mon, 08 Dec 2014 14:22:16 -0800 [thread overview]
Message-ID: <54862498.8080101@gmail.com> (raw)
In-Reply-To: <1418075148-8752-1-git-send-email-olof@lixom.net>
On 08/12/14 13:45, Olof Johansson wrote:
> Fixes the following sparse warning:
> arch/arm/mach-bcm/bcm_kona_smc.c:145:21: warning: incorrect type in initializer (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:145:21: expected unsigned int [usertype] *args
> arch/arm/mach-bcm/bcm_kona_smc.c:145:21: got void [noderef] <asn:2>*static [toplevel] [assigned] bcm_smc_buffer
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: expected void volatile [noderef] <asn:2>*addr
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: got unsigned int [usertype] *
> [+ 2 more instances]
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>
> Florian, should we just apply this directly on arm-soc?
Yes please.
>
>
> -Olof
>
> arch/arm/mach-bcm/bcm_kona_smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
> index a55a7ec..d506d17 100644
> --- a/arch/arm/mach-bcm/bcm_kona_smc.c
> +++ b/arch/arm/mach-bcm/bcm_kona_smc.c
> @@ -142,7 +142,7 @@ static int bcm_kona_do_smc(u32 service_id, u32 buffer_phys)
> static void __bcm_kona_smc(void *info)
> {
> struct bcm_kona_smc_data *data = info;
> - u32 *args = bcm_smc_buffer;
> + u32 __iomem *args = bcm_smc_buffer;
Your fix looks good to me, although the original code sounds a little
dubious, especially in LPAE environment.
>
> BUG_ON(smp_processor_id() != 0);
> BUG_ON(!args);
>
next prev parent reply other threads:[~2014-12-08 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 21:45 [PATCH] ARM: bcm: fix __iomem annotation on kona_smc Olof Johansson
2014-12-08 22:22 ` Florian Fainelli [this message]
2014-12-09 8:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54862498.8080101@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).