From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: add 32bit support to GICv3
Date: Thu, 11 Dec 2014 15:40:31 +0000 [thread overview]
Message-ID: <5489BAEF.5050809@arm.com> (raw)
In-Reply-To: <20141211143205.GP11285@n2100.arm.linux.org.uk>
On 11/12/14 14:32, Russell King - ARM Linux wrote:
> On Thu, Dec 11, 2014 at 02:23:08PM +0000, Jean-Philippe Brucker wrote:
>> +#ifndef __ASM_ARCH_GICV3_H
>> +#define __ASM_ARCH_GICV3_H
>> +
>> +#ifndef __ASSEMBLY__
>> +
>> +#include <asm/io.h>
>
> This should be linux/io.h
Also, you should probably move the #ifndef down to the level of the
inline functions. The #defines are perfectly usable in assembly context.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-12-11 15:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 14:23 [PATCH 0/4] GICv3: add 32bit compatibility Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 1/4] arm64: GICv3: refactor the AArch64 specific parts Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 2/4] arm64: GICv3: change unsigned types for AArch32 compatibility Jean-Philippe Brucker
2014-12-18 13:27 ` Vladimir Murzin
2014-12-18 14:42 ` Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 3/4] arm64: GICv3: Specialize readq and writeq accesses Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 4/4] ARM: add 32bit support to GICv3 Jean-Philippe Brucker
2014-12-11 14:32 ` Russell King - ARM Linux
2014-12-11 15:40 ` Marc Zyngier [this message]
2014-12-11 16:57 ` Jean-Philippe Brucker
2014-12-11 17:23 ` Marc Zyngier
2014-12-11 17:38 ` [PATCH 0/4] GICv3: add 32bit compatibility Marc Zyngier
2014-12-12 16:39 ` Andre Przywara
2014-12-12 16:52 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5489BAEF.5050809@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).