From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomi.valkeinen@ti.com (Tomi Valkeinen) Date: Thu, 18 Dec 2014 16:05:01 +0200 Subject: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c In-Reply-To: <5492DB1A.2020704@gmail.com> References: <54920A54.2060608@gmail.com> <5492ABE7.1060900@samsung.com> <5492D80E.3010906@gmail.com> <1418909978.2236.0.camel@pengutronix.de> <5492DB1A.2020704@gmail.com> Message-ID: <5492DF0D.3080607@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18/12/14 15:48, nick wrote: > Lucas, > That's fair do you known of anyone who does have the hardware so we can test my patch. If you do then we can get this fixed rather > easily. > Cheers Nick > > On 2014-12-18 08:39 AM, Lucas Stach wrote: >> Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick: >>> Krzysztof, >>> If we look at the code for this function, it already is handling the data correctly. In addition the locks >>> seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting >>> the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying >>> around through to test it. >> >> If you can't test it, don't touch it. It's that simple. There seems to be multiple msleep(20)s in exynos_mipi_dsi_common.c, a few with /* FIXME */ and a few without any comments. Looks like bad (but relatively harmless) code to me, but as Lucas said, if you can't test it, don't touch it. Tomi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: