From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: invoke clk_disable_unused() after resume
Date: Thu, 18 Dec 2014 14:48:33 -0800 [thread overview]
Message-ID: <549359C1.3010301@codeaurora.org> (raw)
In-Reply-To: <1418941106-5930-1-git-send-email-jim2101024@gmail.com>
On 12/18/2014 02:18 PM, Jim Quinlan wrote:
> In a discussion[1], mturquette made the suggestion that
>
> "It might be a good idea to call clk_disable_unused()
> from the clk core after resuming from suspend."
>
> This commit does exactly that. For Broadcom STB chips, clocks
> may come up after resume in an "on" state, so calling
> clk_disable_unused() again will turn off clocks that should
> be off.
>
> [1] https://lkml.org/lkml/2014/11/17/666
>
> Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
>
It would be better to use the driver core or syscore suspend/resume
hooks to restore the state of the clocks as they were when the system
was suspended. Plus it would make more sense to do this on a
case-by-case basis instead of assuming that all platforms have clocks
that are left on out of resume. It could still be generic by exporting
the clk_disable_unused() function to drivers so they can call it if they
need to but I don't see why we want to force this on every platform for
every suspend/resume cycle.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2014-12-18 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 22:18 [PATCH] clk: invoke clk_disable_unused() after resume Jim Quinlan
2014-12-18 22:48 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549359C1.3010301@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).