* [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform
@ 2014-12-18 23:13 Alexandre Belloni
2014-12-19 8:20 ` Alexander Stein
2014-12-19 14:53 ` Sergei Shtylyov
0 siblings, 2 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-12-18 23:13 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
at91 will no longer export the mach/cpu.h and mach/hardware.h header files
in the future, which would break building the atmel ac97c driver.
Since the cpu_is_* check is only used to find out whether we are running
on avr32 or arm/at91, we can hardcode that check in the ARM case.
Unfortunately the driver is missing other work to be useful again on ARM,
if anyone wants to actually use it, they need to add a DT binding, and
the driver should really be converted to use the ASoC framework.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: http://www.spinics.net/lists/arm-kernel/msg382068.html
---
sound/atmel/ac97c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index b59427d5a697..83975f8d5947 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -34,10 +34,10 @@
#include <linux/platform_data/dma-dw.h>
#include <linux/dma/dw.h>
+#ifdef CONFIG_AVR32
#include <mach/cpu.h>
-
-#ifdef CONFIG_ARCH_AT91
-#include <mach/hardware.h>
+#else
+#define cpu_is_at32ap7000() (0)
#endif
#include "ac97c.h"
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform
2014-12-18 23:13 [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform Alexandre Belloni
@ 2014-12-19 8:20 ` Alexander Stein
2014-12-19 9:13 ` Alexandre Belloni
2014-12-19 14:53 ` Sergei Shtylyov
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2014-12-19 8:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alexandre,
Am Freitag 19 Dezember 2014, 00:13:10 schrieb Alexandre Belloni:
> From: Arnd Bergmann <arnd@arndb.de>
>
> at91 will no longer export the mach/cpu.h and mach/hardware.h header files
> in the future, which would break building the atmel ac97c driver.
>
> Since the cpu_is_* check is only used to find out whether we are running
> on avr32 or arm/at91, we can hardcode that check in the ARM case.
>
> Unfortunately the driver is missing other work to be useful again on ARM,
> if anyone wants to actually use it, they need to add a DT binding, and
> the driver should really be converted to use the ASoC framework.
I recently send 3 patches to make DT working with this driver, you were on CC :). Please refer to http://comments.gmane.org/gmane.linux.alsa.devel/131686
I wonder though why all 3 are listed there although they were sent to different lists.
Best regards,
Alexander
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform
2014-12-18 23:13 [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform Alexandre Belloni
2014-12-19 8:20 ` Alexander Stein
@ 2014-12-19 14:53 ` Sergei Shtylyov
2014-12-19 17:02 ` Alexandre Belloni
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2014-12-19 14:53 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 12/19/2014 2:13 AM, Alexandre Belloni wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> at91 will no longer export the mach/cpu.h and mach/hardware.h header files
> in the future, which would break building the atmel ac97c driver.
> Since the cpu_is_* check is only used to find out whether we are running
> on avr32 or arm/at91, we can hardcode that check in the ARM case.
> Unfortunately the driver is missing other work to be useful again on ARM,
> if anyone wants to actually use it, they need to add a DT binding, and
> the driver should really be converted to use the ASoC framework.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Link: http://www.spinics.net/lists/arm-kernel/msg382068.html
> ---
> sound/atmel/ac97c.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index b59427d5a697..83975f8d5947 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -34,10 +34,10 @@
> #include <linux/platform_data/dma-dw.h>
> #include <linux/dma/dw.h>
>
> +#ifdef CONFIG_AVR32
> #include <mach/cpu.h>
> -
> -#ifdef CONFIG_ARCH_AT91
> -#include <mach/hardware.h>
> +#else
> +#define cpu_is_at32ap7000() (0)
() around 0 not needed at all.
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform
2014-12-19 14:53 ` Sergei Shtylyov
@ 2014-12-19 17:02 ` Alexandre Belloni
2014-12-20 20:21 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Belloni @ 2014-12-19 17:02 UTC (permalink / raw)
To: linux-arm-kernel
Arnd,
On 19/12/2014 at 17:53:44 +0300, Sergei Shtylyov wrote :
> >+#define cpu_is_at32ap7000() (0)
>
> () around 0 not needed at all.
>
Do you want me to fix that and resubmit? I don't have strong opinion
about this.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform
2014-12-19 17:02 ` Alexandre Belloni
@ 2014-12-20 20:21 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2014-12-20 20:21 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 19 December 2014 18:02:21 Alexandre Belloni wrote:
> Arnd,
>
> On 19/12/2014 at 17:53:44 +0300, Sergei Shtylyov wrote :
> > >+#define cpu_is_at32ap7000() (0)
> >
> > () around 0 not needed at all.
> >
>
> Do you want me to fix that and resubmit? I don't have strong opinion
> about this.
Yes, no point debating over this. I copied the definition from
arch/arm/mach-at91/include/mach/cpu.h and didn't want to do any
style changes, otherwise I'd probably have turned it into an
inline function, but any version that works is fine with me.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-20 20:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-18 23:13 [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform Alexandre Belloni
2014-12-19 8:20 ` Alexander Stein
2014-12-19 9:13 ` Alexandre Belloni
2014-12-19 14:53 ` Sergei Shtylyov
2014-12-19 17:02 ` Alexandre Belloni
2014-12-20 20:21 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).