From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mmc: dw_mmc: Generic MMC tuning with the clock phase framework
Date: Fri, 19 Dec 2014 10:29:17 -0800 [thread overview]
Message-ID: <54946E7D.1010500@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=WhB84enspDCHwkc2TqEFeAr_qiY4m_xYvMYCArUAtPXw@mail.gmail.com>
On 12/18/2014 04:20 PM, Doug Anderson wrote:
> Alex,
>
> On Thu, Dec 18, 2014 at 3:01 PM, Alexandru M Stan <amstan@chromium.org> wrote:
>> + blk_test = kmalloc(blksz, GFP_KERNEL);
>> + if (!blk_test)
>> + return -ENOMEM;
>> +
>> + ranges = kmalloc(((NUM_PHASES / 2 + 1) * sizeof(ranges)), GFP_KERNEL);
> sizeof(*ranges)
>
>
> Other than that, this looks good to me and you can add my reviewed-by
> when the above is fixed.
>
>
Might want to use kmalloc_array() too.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2014-12-19 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 23:01 [PATCH 0/3] mmc: dw_mmc: Generic clock phase tuning that works with rk3288 (possibly more!) Alexandru M Stan
2014-12-18 23:01 ` [PATCH 1/3] mmc: dw_mmc: dt-binding: Add tuning related things Alexandru M Stan
2014-12-19 0:36 ` Doug Anderson
2014-12-18 23:01 ` [PATCH 2/3] mmc: dw_mmc: Generic MMC tuning with the clock phase framework Alexandru M Stan
2014-12-19 0:20 ` Doug Anderson
2014-12-19 18:29 ` Stephen Boyd [this message]
2014-12-19 8:51 ` Ulf Hansson
2014-12-18 23:01 ` [PATCH 3/3] ARM: dts: rk3288: Add drive/sample clocks for dw_mmc devices Alexandru M Stan
2014-12-19 0:21 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54946E7D.1010500@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).