[PATCH 48/62] ARM: s3c64xx: select power domains only when used

Kukjin Kim
2014-03-20T22:39:41Z

On 03/21/14 03:14, Kukjin Kim wrote:
> On 03/20/14 12:56, Kukjin Kim wrote:
>> Arnd Bergmann wrote:
>>>
>>> The power domain code is only available when CONFIG_PM
>>> is enabled, so we must not select that unconditionally for
>>> s3c64xx. Changing it to 'select PM_GENERIC_DOMAINS if PM'
>>> mirrors what we do on other platforms, and fixes a possible
>>> randconfig build bug.
>>>
>>> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
>>> Cc: Tomasz Figa<tomasz.figa@gmail.com>
>>> Cc: Kukjin Kim<kgene.kim@samsung.com>
>>
>> Acked-by: Kukjin Kim<kgene.kim@samsung.com>
>>
>
> Arnd,
>
> Please drop this patch in your tree because there is a fix before this
> and it fixes SAMSUNG_WAKEMASK dependency together for S3C64XX.
>
> [PATCH v2 5/6] ARM: s3c64xx: Fix incorrect selection of PM-related
> symbols <http://www.spinics.net/lists/arm-kernel/msg316391.html>
>
> Note, I'll take above into 2nd fixes for v3.15 in samsung tree.
>
> If any problems, please kindly let me know.
>
Oops, Arnd sorry.

Please go ahead with my ack on this because the fix, "[PATCH v2 5/6]
ARM: s3c64xx: Fix incorrect selection of PM-related symbols" makes a
build error...I'll look at the problem.

Thanks,
Kukjin

>>
>>> Cc: Ben Dooks<ben-linux@fluff.org>
>>> ---
>>> arch/arm/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index 4721007..6ffcadd 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -764,7 +764,7 @@ config ARCH_S3C64XX
>>> select HAVE_TCM
>>> select NO_IOPORT
>>> select PLAT_SAMSUNG
>>> - select PM_GENERIC_DOMAINS
>>> + select PM_GENERIC_DOMAINS if PM
>>> select S3C_DEV_NAND
>>> select S3C_GPIO_TRACK
>>> select SAMSUNG_ATAGS
>>> --
>>> 1.8.3.2