From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: Use PMC scratch register 40 for tegra_resume() location store
Date: Mon, 22 Dec 2014 09:17:45 -0700 [thread overview]
Message-ID: <54984429.8040905@wwwdotorg.org> (raw)
In-Reply-To: <1419202392-1159-1-git-send-email-digetx@gmail.com>
On 12/21/2014 03:52 PM, Dmitry Osipenko wrote:
> Commit 7232398abc6a ("ARM: tegra: Convert PMC to a driver") changed tegra_resume()
> location storing from late to early and as result broke suspend on tegra20.
> PMC scratch register 41 was used by tegra lp1 suspend core code for storing
> physical memory address of common resume function and in the same time used by
> tegra20 cpuidle driver for storing cpu1 "resettable" status, so it implied
> strict order of scratch register use. Fix it by using scratch 40 instead of 41
> for tegra_resume() location store.
You likely can't simply change the PMC scratch register usage
arbitrarily; specific registers are designated for specific purposes,
and code outside the Linux kernel (bootloaders, LP0 resume code, secure
monitors, etc.) may depend on those specific values being in those
registers. Without significant research, I'd suggest not changing the
PMC scratch register usage.
next prev parent reply other threads:[~2014-12-22 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 22:52 [PATCH] ARM: tegra: Use PMC scratch register 40 for tegra_resume() location store Dmitry Osipenko
2014-12-22 16:17 ` Stephen Warren [this message]
2014-12-22 17:27 ` Dmitry Osipenko
2014-12-22 18:00 ` Stephen Warren
2015-01-08 10:57 ` Thierry Reding
2015-01-08 12:37 ` Peter De Schrijver
2015-01-09 9:51 ` Thierry Reding
2015-01-09 10:29 ` Peter De Schrijver
2015-01-09 14:36 ` Dmitry Osipenko
2015-01-09 16:57 ` Stephen Warren
2015-01-09 17:07 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54984429.8040905@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).