From: pankaj.dubey@samsung.com (Pankaj Dubey)
To: linux-arm-kernel@lists.infradead.org
Subject: clk: samsung: exynos7: Add clocks for MSCL block
Date: Tue, 23 Dec 2014 10:29:22 +0530 [thread overview]
Message-ID: <5498F6AA.8010405@samsung.com> (raw)
In-Reply-To: <1418801617-7593-1-git-send-email-tony.kn@samsung.com>
Hi Tony,
On Wednesday 17 December 2014 01:03 PM, tony nadackal wrote:
> Add clock support for the MSCL block for Exynos7.
>
> Signed-off-by: Tony K Nadackal <tony.kn@samsung.com>
>
> ---
> .../devicetree/bindings/clock/exynos7-clock.txt | 1 +
> drivers/clk/samsung/clk-exynos7.c | 124 +++++++++++++++++++++
> include/dt-bindings/clock/exynos7-clk.h | 40 ++++++-
> 3 files changed, 164 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/exynos7-clock.txt b/Documentation/devicetree/bindings/clock/exynos7-clock.txt
> index 6d3d5f8..d0e048c 100644
> --- a/Documentation/devicetree/bindings/clock/exynos7-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/exynos7-clock.txt
> @@ -34,6 +34,7 @@ Required Properties for Clock Controller:
> - "samsung,exynos7-clock-peris"
> - "samsung,exynos7-clock-fsys0"
> - "samsung,exynos7-clock-fsys1"
> + - "samsung,exynos7-clock-mscl"
>
> - reg: physical base address of the controller and the length of
> memory mapped region.
> diff --git a/drivers/clk/samsung/clk-exynos7.c b/drivers/clk/samsung/clk-exynos7.c
> index a79bf23..95c1160 100644
> --- a/drivers/clk/samsung/clk-exynos7.c
> +++ b/drivers/clk/samsung/clk-exynos7.c
> @@ -34,6 +34,7 @@
> #define DIV_TOPC0 0x0600
> #define DIV_TOPC1 0x0604
> #define DIV_TOPC3 0x060C
> +#define ENABLE_ACLK_TOPC1 0x0804
nit: Tab space between #define and ENABLE_ACLK_TOPC1, should be removed.
I verified register settings and clock relationships are as per UM I
have with me. So other than above nit, everything looks fine.
Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Thanks,
Pankaj Dubey
next prev parent reply other threads:[~2014-12-23 4:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 7:33 [PATCH] clk: samsung: exynos7: Add clocks for MSCL block Tony K Nadackal
2014-12-19 16:21 ` Sylwester Nawrocki
2014-12-22 11:46 ` Tony K Nadackal
2014-12-22 14:57 ` Sylwester Nawrocki
2014-12-23 8:13 ` Tony K Nadackal
2014-12-23 4:59 ` Pankaj Dubey [this message]
2014-12-23 11:55 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5498F6AA.8010405@samsung.com \
--to=pankaj.dubey@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).