From: Andrew.Jackson@arm.com (Andrew Jackson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/5] ASoC: dwc: Switch to managed clock resource
Date: Wed, 24 Dec 2014 06:54:25 +0000 [thread overview]
Message-ID: <549A6321.3000703@arm.com> (raw)
In-Reply-To: <9af8128918e2da97801f1122ae06336b1bd1012f.1419342218.git.Andrew.Jackson@arm.com>
On 12/23/14 13:56, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
>
> Simplify error handling during probe by using managed clock
> resources.
In my haste to get to the Christmas turkey I missed a clk_put elsewhere. Will fix and resubmit.
Andrew
> Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
> ---
> sound/soc/dwc/designware_i2s.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 9573ec7..b3dc535 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -407,13 +407,13 @@ static int dw_i2s_probe(struct platform_device *pdev)
>
> dev->capability = pdata->cap;
> dev->i2s_clk_cfg = pdata->i2s_clk_cfg;
> - dev->clk = clk_get(&pdev->dev, NULL);
> + dev->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(dev->clk))
> return PTR_ERR(dev->clk);
>
> ret = clk_prepare_enable(dev->clk);
> if (ret < 0)
> - goto err_clk_put;
> + return ret;
>
> dev_set_drvdata(&pdev->dev, dev);
> ret = snd_soc_register_component(&pdev->dev, &dw_i2s_component,
> @@ -427,8 +427,6 @@ static int dw_i2s_probe(struct platform_device *pdev)
>
> err_clk_disable:
> clk_disable(dev->clk);
> -err_clk_put:
> - clk_put(dev->clk);
> return ret;
> }
>
>
next prev parent reply other threads:[~2014-12-24 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 13:56 [PATCH v4 0/5] ASoC: dwc: Add device tree support to designware I2S Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 1/5] ASoC: dwc: Prepare clock before use Andrew Jackson
2014-12-24 6:56 ` Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 2/5] ASoC: dwc: Switch to managed clock resource Andrew Jackson
2014-12-24 6:54 ` Andrew Jackson [this message]
2014-12-23 13:56 ` [PATCH v4 3/5] ASoC: dwc: Read I2S block configuration from registers Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 4/5] ASoC: dwc: Add documentation for I2S DT Andrew Jackson
2014-12-23 13:56 ` [PATCH v4 5/5] ASoC: dwc: Add devicetree support for Designware I2S Andrew Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549A6321.3000703@arm.com \
--to=andrew.jackson@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).