From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 2/8] ARM: l2c: Refactor the driver to use commit-like interface
Date: Fri, 2 Jan 2015 09:36:03 -0600 [thread overview]
Message-ID: <54A6BAE3.70204@ti.com> (raw)
In-Reply-To: <54A664AB.1060100@gmail.com>
On 01/02/2015 03:28 AM, Tomasz Figa wrote:
>
>
> On 02.01.2015 18:13, Tomasz Figa wrote:
>> On 30.12.2014 23:51, Nishanth Menon wrote:
>>>>> Looks like the following also need addressing:
>>>>> data->save is called twice (once more after l2cof_init)
>>>>> l2c310_init_fns also needs l2c310_configure
>>>>> will be nice to use l2x0_data only after we kmemdup data in __l2c_init
>>>>
>>>> I'll check this.
>>> Thanks.
>>>
>>
>> Apparently the second save in __l2c_init() is not needed and it should
>> have been removed. However it might be a good idea to actually do second
>> save in l2c_enable() after l2c_configure() so that the values actually
>> permitted by hardware and/or secure firmware are stored.
>>
>> l2c310_init_fns needs to be updated indeed.
>
> Hmm, apparently current patch already adds this (and I missed it reading
> it at first), so I'm not sure what's your concern about it.
Uggh.. looks like I missed the same as well :( Sorry about that..
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-01-02 15:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 10:48 [PATCH v10 0/8] Enable L2 cache support on Exynos4210/4x12 SoCs Marek Szyprowski
2014-12-23 10:48 ` [PATCH v10 1/8] ARM: OMAP2+: use common l2cache initialization code Marek Szyprowski
2014-12-23 10:48 ` [PATCH v10 2/8] ARM: l2c: Refactor the driver to use commit-like interface Marek Szyprowski
2014-12-23 17:06 ` Tony Lindgren
2014-12-23 17:13 ` Nishanth Menon
2014-12-28 11:34 ` Tomasz Figa
2014-12-29 14:29 ` Nishanth Menon
2014-12-29 18:23 ` Nishanth Menon
2014-12-30 9:05 ` Tomasz Figa
2014-12-30 14:51 ` Nishanth Menon
2015-01-02 9:13 ` Tomasz Figa
2015-01-02 9:28 ` Tomasz Figa
2015-01-02 15:36 ` Nishanth Menon [this message]
2015-01-02 15:38 ` Nishanth Menon
2015-01-02 8:55 ` Tomasz Figa
2015-01-02 17:57 ` Nishanth Menon
2014-12-23 10:48 ` [PATCH v10 3/8] ARM: l2c: Add interface to ask hypervisor to configure L2C Marek Szyprowski
2014-12-23 10:48 ` [PATCH v10 4/8] ARM: l2c: Get outer cache .write_sec callback from mach_desc only if not NULL Marek Szyprowski
2014-12-23 10:48 ` [PATCH v10 5/8] ARM: l2c: Add support for overriding prefetch settings Marek Szyprowski
2014-12-23 10:48 ` [PATCH v10 6/8] ARM: EXYNOS: Add .write_sec outer cache callback for L2C-310 Marek Szyprowski
2014-12-23 10:48 ` [PATCH v10 7/8] ARM: EXYNOS: Add support for non-secure L2X0 resume Marek Szyprowski
2014-12-23 10:48 ` [PATCH v10 8/8] ARM: dts: exynos4: Add nodes for L2 cache controller Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A6BAE3.70204@ti.com \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).