Tegra 2 T20 NAND Flash Support

Tegra 2 T20 NAND Flash Support

[Marcel Ziswiler]

Sorry for referring to an old post of yours:

 > From: Thierry Reding <thierry.reding@...>
 > Subject: Re: [PATCH V5 7/9] ARM: dts: tegra: add non-removable and 
keep-power-in-suspend property for MMC
 > Date: 2013-04-03 05:45:49 GMT (1 year, 8 weeks, 5 days, 12 hours and 
59 minutes ago)
 > ...
 > For Tegra20 Tamonten we don't use eMMC. Ideally we'd be using NAND to
 > boot from but that doesn't have mainline support. I have a semi-working
 > patch and will probably spend some more time getting it ready. The MMC
 > cards are all removable, though I guess since they are the boot device
 > they still should remain powered in suspend?

You might have noticed our current effort in further mainlining 
Apalis/Colibri T30 module support. In the same respect we are looking at 
further improving Colibri T20 support. One of the major missing pieces 
is of course the NAND support you were mentioning in that 14 months old 
post. Have you by any chance made any progress on this? As me (on PXA) 
and Stefan (on Vybrid) do have quite some experience in the MTD NAND 
infrastructure there might be a chance for some joint effort in that 
respect. What do you think? Of course any other contribution/feedback is 
also most welcome.

Tegra 2 T20 NAND Flash Support

[Lucas Stach]

Hi Marcel,

Am Mittwoch, den 04.06.2014, 03:00 +0200 schrieb Marcel Ziswiler:
> Sorry for referring to an old post of yours:
> 
>  > From: Thierry Reding <thierry.reding@...>
>  > Subject: Re: [PATCH V5 7/9] ARM: dts: tegra: add non-removable and 
> keep-power-in-suspend property for MMC
>  > Date: 2013-04-03 05:45:49 GMT (1 year, 8 weeks, 5 days, 12 hours and 
> 59 minutes ago)
>  > ...
>  > For Tegra20 Tamonten we don't use eMMC. Ideally we'd be using NAND to
>  > boot from but that doesn't have mainline support. I have a semi-working
>  > patch and will probably spend some more time getting it ready. The MMC
>  > cards are all removable, though I guess since they are the boot device
>  > they still should remain powered in suspend?
> 
> You might have noticed our current effort in further mainlining 
> Apalis/Colibri T30 module support. In the same respect we are looking at 
> further improving Colibri T20 support. One of the major missing pieces 
> is of course the NAND support you were mentioning in that 14 months old 
> post. Have you by any chance made any progress on this? As me (on PXA) 
> and Stefan (on Vybrid) do have quite some experience in the MTD NAND 
> infrastructure there might be a chance for some joint effort in that 
> respect. What do you think? Of course any other contribution/feedback is 
> also most welcome.

I took the Linux Tegra NAND driver from Thierry and cleaned it up quite
a bit. It now works with both ONFI and non-ONFI NAND, at least for
reading. Writing doesn't quite work yet and I've got side-tracked with
other stuff.

If you are interested in moving this forward I can put up my WIP patches
to some public location.

Regards,
Lucas

Tegra 2 T20 NAND Flash Support

[Marcel Ziswiler]

On 06/04/2014 09:18 AM, Lucas Stach wrote:
> I took the Linux Tegra NAND driver from Thierry and cleaned it up quite
> a bit. It now works with both ONFI and non-ONFI NAND, at least for
> reading. Writing doesn't quite work yet and I've got side-tracked with
> other stuff.
>
> If you are interested in moving this forward I can put up my WIP patches
> to some public location.

Sounds great, yes. That would be perfect, thanks.

We even once got an universal NAND test infrastructure from Micron based 
on a re-worked Colibri T20 which we could use to validate it with 
various NAND flash parts.

Tegra 2 T20 NAND Flash Support

[Thierry Reding]

On Wed, Jun 04, 2014 at 09:23:22AM +0200, Marcel Ziswiler wrote:
> On 06/04/2014 09:18 AM, Lucas Stach wrote:
> >I took the Linux Tegra NAND driver from Thierry and cleaned it up quite
> >a bit. It now works with both ONFI and non-ONFI NAND, at least for
> >reading. Writing doesn't quite work yet and I've got side-tracked with
> >other stuff.
> >
> >If you are interested in moving this forward I can put up my WIP patches
> >to some public location.
> 
> Sounds great, yes. That would be perfect, thanks.
> 
> We even once got an universal NAND test infrastructure from Micron based on
> a re-worked Colibri T20 which we could use to validate it with various NAND
> flash parts.

Excellent, I would've had a hard time digging up those patches. It's
really been quite a while.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140604/61b51825/attachment.sig>

Tegra 2 T20 NAND Flash Support

[Lucas Stach]

Am Mittwoch, den 04.06.2014, 16:41 +0200 schrieb Thierry Reding:
> On Wed, Jun 04, 2014 at 09:23:22AM +0200, Marcel Ziswiler wrote:
> > On 06/04/2014 09:18 AM, Lucas Stach wrote:
> > >I took the Linux Tegra NAND driver from Thierry and cleaned it up quite
> > >a bit. It now works with both ONFI and non-ONFI NAND, at least for
> > >reading. Writing doesn't quite work yet and I've got side-tracked with
> > >other stuff.
> > >
> > >If you are interested in moving this forward I can put up my WIP patches
> > >to some public location.
> > 
> > Sounds great, yes. That would be perfect, thanks.
> > 
> > We even once got an universal NAND test infrastructure from Micron based on
> > a re-worked Colibri T20 which we could use to validate it with various NAND
> > flash parts.
> 
> Excellent, I would've had a hard time digging up those patches. It's
> really been quite a while.
> 
I've put up a rebased version of the patches at

git://git.pengutronix.de/git/lst/linux.git tegra-nand

Regards,
Lucas

Tegra 2 T20 NAND Flash Support

[Lucas Stach]

Am Mittwoch, den 04.06.2014, 19:32 +0200 schrieb Lucas Stach:
> Am Mittwoch, den 04.06.2014, 16:41 +0200 schrieb Thierry Reding:
> > On Wed, Jun 04, 2014 at 09:23:22AM +0200, Marcel Ziswiler wrote:
> > > On 06/04/2014 09:18 AM, Lucas Stach wrote:
> > > >I took the Linux Tegra NAND driver from Thierry and cleaned it up quite
> > > >a bit. It now works with both ONFI and non-ONFI NAND, at least for
> > > >reading. Writing doesn't quite work yet and I've got side-tracked with
> > > >other stuff.
> > > >
> > > >If you are interested in moving this forward I can put up my WIP patches
> > > >to some public location.
> > > 
> > > Sounds great, yes. That would be perfect, thanks.
> > > 
> > > We even once got an universal NAND test infrastructure from Micron based on
> > > a re-worked Colibri T20 which we could use to validate it with various NAND
> > > flash parts.
> > 
> > Excellent, I would've had a hard time digging up those patches. It's
> > really been quite a while.
> > 
> I've put up a rebased version of the patches at
> 
> git://git.pengutronix.de/git/lst/linux.git tegra-nand
> 
For those still interested:
I've continued to work on this for the last few days and pushed a new
version of my WIP to the above location.

It is now in a state where the in-kernel mtd tests seem to be happy with
it. Also creating/using a filesystem on top of the mtdblock device seems
to work properly.

I still need to validate that anything using the OOB areas is working
properly. The last missing feature is BCH ECC support, but that should
be easy to add.

I don't know if it still needs some performance tuning. 5MB/s write and
12,5MB/s read on a Colibri T20 seem pretty slow me, but I have nothing
to compare with ATM.
Marcel could you maybe dig out some benchmarks with L4T?

Regards,
Lucas

Tegra 2 T20 NAND Flash Support

[Stephen Warren]

On 01/03/2015 12:50 PM, Lucas Stach wrote:
> Am Mittwoch, den 04.06.2014, 19:32 +0200 schrieb Lucas Stach:
>> Am Mittwoch, den 04.06.2014, 16:41 +0200 schrieb Thierry Reding:
>>> On Wed, Jun 04, 2014 at 09:23:22AM +0200, Marcel Ziswiler wrote:
>>>> On 06/04/2014 09:18 AM, Lucas Stach wrote:
>>>>> I took the Linux Tegra NAND driver from Thierry and cleaned it up quite
>>>>> a bit. It now works with both ONFI and non-ONFI NAND, at least for
>>>>> reading. Writing doesn't quite work yet and I've got side-tracked with
>>>>> other stuff.
>>>>>
>>>>> If you are interested in moving this forward I can put up my WIP patches
>>>>> to some public location.
>>>>
>>>> Sounds great, yes. That would be perfect, thanks.
>>>>
>>>> We even once got an universal NAND test infrastructure from Micron based on
>>>> a re-worked Colibri T20 which we could use to validate it with various NAND
>>>> flash parts.
>>>
>>> Excellent, I would've had a hard time digging up those patches. It's
>>> really been quite a while.
>>>
>> I've put up a rebased version of the patches at
>>
>> git://git.pengutronix.de/git/lst/linux.git tegra-nand
>>
> For those still interested:
> I've continued to work on this for the last few days and pushed a new
> version of my WIP to the above location.
> 
> It is now in a state where the in-kernel mtd tests seem to be happy with
> it. Also creating/using a filesystem on top of the mtdblock device seems
> to work properly.
> 
> I still need to validate that anything using the OOB areas is working
> properly. The last missing feature is BCH ECC support, but that should
> be easy to add.
> 
> I don't know if it still needs some performance tuning. 5MB/s write and
> 12,5MB/s read on a Colibri T20 seem pretty slow me, but I have nothing
> to compare with ATM.
> Marcel could you maybe dig out some benchmarks with L4T?

That sounds pretty similar to the eMMC on devices of that age (at least
with the upstream drivers that don't support fast transfer modes) so
it's probably not bad...