From mboxrd@z Thu Jan 1 00:00:00 1970 From: svarbanov@mm-sol.com (Stanimir Varbanov) Date: Tue, 06 Jan 2015 17:24:22 +0200 Subject: [PATCH 5/5] ARM: qcom: Add Qualcomm APQ8084 SoC In-Reply-To: <1671186.DiHNtkP1SP@wuerfel> References: <1418404441-5518-1-git-send-email-svarbanov@mm-sol.com> <1418404441-5518-6-git-send-email-svarbanov@mm-sol.com> <1671186.DiHNtkP1SP@wuerfel> Message-ID: <54ABFE26.9010208@mm-sol.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, Thanks for the comments! On 12/12/2014 07:33 PM, Arnd Bergmann wrote: > On Friday 12 December 2014 19:14:01 Stanimir Varbanov wrote: >> +config ARCH_APQ8084 >> + bool "Enable support for APQ8084" >> + select HAVE_ARM_ARCH_TIMER >> + select PCI >> + select PCI_DOMAINS >> + select PCI_MSI >> + > > I would prefer not to see 'select PCI' here. Also the driver is written > to work without PCI_MSI, so I'd be much happier with just > > config ARCH_APQ8084 > bool "Enable support for APQ8084" > select HAVE_ARM_ARCH_TIMER > select PCI_DOMAINS if PCI What about this config ARCH_APQ8084 bool "Enable support for APQ8084" select HAVE_ARM_ARCH_TIMER select MIGHT_HAVE_PCI select PCI_DOMAINS if PCI -- regards, Stan