From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@linaro.org (Grygorii.Strashko@linaro.org) Date: Thu, 08 Jan 2015 18:32:27 +0200 Subject: [PATCH 1/4] usb: phy: Fix deferred probing In-Reply-To: References: <1420559110-8043-1-git-send-email-maxime.ripard@free-electrons.com> <1420559110-8043-2-git-send-email-maxime.ripard@free-electrons.com> Message-ID: <54AEB11B.6060403@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 01/07/2015 06:41 AM, Olof Johansson wrote: > On Tue, Jan 6, 2015 at 7:45 AM, Maxime Ripard > wrote: >> Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on >> failure") actually broke the deferred probing mechanism, since it now returns >> EPROBE_DEFER only when the try_module_get call fails, but not when the phy >> lookup does. >> >> All the other similar functions seem to return ENODEV when try_module_get >> fails, and the error code of either __usb_find_phy or __of_usb_find_phy >> otherwise. >> >> In order to have a consistent behaviour, and a meaningful EPROBE_DEFER, always >> return EPROBE_DEFER when __(of_)usb_find_phy fails to look up the requested >> phy, that will be propagated by the caller, and ENODEV if try_module_get fails. >> > > Fixes: 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error > on failure") > >> Signed-off-by: Maxime Ripard > > This also fixes USB on tegra/trimslice here. > > Tested-by: Olof Johansson > > Given that the regression went in during 3.19 merge window, this > should go in as a fix during -rc, please. 1) Pls note, there is a duplication patch https://www.mail-archive.com/linux-usb at vger.kernel.org/msg53893.html but this one is more correct as for me. 2) This patch fixes USB regression on Keystone 2, so Tested-by: Grygorii Strashko -- regards, -grygorii