From: varkabhadram@gmail.com (Varka Bhadram)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver
Date: Fri, 09 Jan 2015 06:06:05 +0530 [thread overview]
Message-ID: <54AF2275.9050600@gmail.com> (raw)
In-Reply-To: <1420763178-10115-3-git-send-email-andrew@lunn.ch>
On Friday 09 January 2015 05:56 AM, Andrew Lunn wrote:
> The TLC59116 is an I2C bus controlled 16-channel LED driver. Each LED
> output has its own 8-bit fixed-frequency PWM controller to control the
> brightness of the LED.
>
> This is based on a driver from Belkin, but has been extensively
> rewritten.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Cc: Matthew.Fatheree at belkin.com
> ---
> drivers/leds/Kconfig | 7 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-tlc59116.c | 253 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 261 insertions(+)
> create mode 100644 drivers/leds/leds-tlc59116.c
>
(...)
> +static const struct of_device_id of_tlc59116_leds_match[] = {
> + { .compatible = "ti,tlc59116", },
> + {},
> +};
> +
Missing MODULE_DEVICE_TABLE(of, ...)..?
> +static const struct i2c_device_id tlc59116_id[] = {
> + { "tlc59116" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(i2c, tlc59116_id);
> +
> +static struct i2c_driver tlc59116_driver = {
> + .driver = {
> + .name = "tlc59116",
> + .of_match_table = of_match_ptr(of_tlc59116_leds_match),
> +
Remove this unnecessary line space...
> + },
> + .probe = tlc59116_probe,
> + .remove = tlc59116_remove,
> + .id_table = tlc59116_id,
> +};
> +
> +module_i2c_driver(tlc59116_driver);
> +
> +MODULE_AUTHOR("Andrew Lunn <andrew@lunn.ch>");
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("TLC59116 LED driver");
--
Thanks and Regards,
Varka Bhadram.
next prev parent reply other threads:[~2015-01-09 0:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 0:26 [PATCH 0/2] Driver for TI tlc59116 16 Channel i2c LED driver Andrew Lunn
2015-01-09 0:26 ` [PATCH 1/2] leds: tlc59116: Document binding for the TI " Andrew Lunn
2015-01-09 1:02 ` Bryan Wu
2015-01-09 1:34 ` Andrew Lunn
2015-01-09 0:26 ` [PATCH 2/2] leds: tlc59116: Driver " Andrew Lunn
2015-01-09 0:36 ` Varka Bhadram [this message]
2015-01-09 1:42 ` Andrew Lunn
2015-01-09 1:26 ` Bryan Wu
2015-01-09 1:38 ` Andrew Lunn
2015-01-09 12:46 ` Imre Kaloz
2015-01-09 13:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AF2275.9050600@gmail.com \
--to=varkabhadram@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).