From: wangnan0@huawei.com (Wang Nan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v19 08/11] ARM: kprobes: enable OPTPROBES for ARM 32
Date: Fri, 9 Jan 2015 14:51:37 +0800 [thread overview]
Message-ID: <54AF7A79.20500@huawei.com> (raw)
In-Reply-To: <1420457376-77366-1-git-send-email-wangnan0@huawei.com>
Hi Tixy and other,
Similar to patch 01/11, build robot found a building error in this patch when ARM version
is lower than 4. In such processors 'blx' instruction is unusable.
I have posted a new version of this patch, which has following code change:
diff --git a/arch/arm/probes/kprobes/opt-arm.c b/arch/arm/probes/kprobes/opt-arm.c
index 6a60df3..cb47eff 100644
--- a/arch/arm/probes/kprobes/opt-arm.c
+++ b/arch/arm/probes/kprobes/opt-arm.c
@@ -58,7 +58,12 @@ asm (
*/
" and r4, sp, #4\n"
" sub sp, sp, r4\n"
+#if __LINUX_ARM_ARCH__ >= 5
" blx r2\n"
+#else
+ " mov lr, pc\n"
+ " bx r2\n"
+#endif
" add sp, sp, r4\n"
" ldr r1, [sp, #64]\n"
" tst r1, #"__stringify(PSR_T_BIT)"\n"
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/314542.html
Tixy, could you please collect it into your repository and test again?
Thank you!
next prev parent reply other threads:[~2015-01-09 6:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 11:28 [PATCH v19 00/11] ARM: kprobes: OPTPROBES and other improvements Wang Nan
2015-01-05 11:29 ` [PATCH v19 01/11] ARM: probes: move all probe code to dedicate directory Wang Nan
2015-01-09 2:19 ` [PATCH v20 " Wang Nan
2015-01-09 9:47 ` Jon Medhurst (Tixy)
2015-01-09 9:50 ` Wang Nan
2015-01-09 2:28 ` [PATCH v19 " Wang Nan
2015-01-05 11:29 ` [PATCH v19 02/11] ARM: kprobes: remove unused ARM decoder actions Wang Nan
2015-01-07 11:50 ` Jon Medhurst (Tixy)
2015-01-05 11:29 ` [PATCH v19 03/11] ARM: kprobes: introduces checker Wang Nan
2015-01-05 11:29 ` [PATCH v19 04/11] ARM: kprobes: collects stack consumption for store instructions Wang Nan
2015-01-05 11:29 ` [PATCH v19 05/11] ARM: kprobes: disallow probing stack consuming instructions Wang Nan
2015-01-05 11:29 ` [PATCH v19 06/11] ARM: kprobes: Add test cases for " Wang Nan
2015-01-05 11:29 ` [PATCH v19 07/11] kprobes: Pass the original kprobe for preparing optimized kprobe Wang Nan
2015-01-05 11:29 ` [PATCH v19 08/11] ARM: kprobes: enable OPTPROBES for ARM 32 Wang Nan
2015-01-07 13:01 ` Jon Medhurst (Tixy)
2015-01-09 6:37 ` [PATCH v20 " Wang Nan
2015-01-09 10:25 ` Jon Medhurst (Tixy)
2015-01-09 10:55 ` Wang Nan
2015-01-09 16:35 ` Russell King - ARM Linux
2015-01-09 17:28 ` Jon Medhurst (Tixy)
2015-01-09 17:57 ` Russell King - ARM Linux
2015-01-09 19:18 ` Jon Medhurst (Tixy)
2015-01-09 6:51 ` Wang Nan [this message]
2015-01-05 11:29 ` [PATCH v19 09/11] ARM: kprobes: Fix unreliable MRS instruction tests Wang Nan
2015-01-05 11:29 ` [PATCH v19 10/11] ARM: kprobes: check register usage for probed instruction Wang Nan
2015-01-13 15:01 ` Jon Medhurst (Tixy)
2015-01-13 16:13 ` [PATCH] " Jon Medhurst (Tixy)
2015-01-19 10:37 ` Wang Nan
2015-01-05 11:34 ` [PATCH v19 11/11] ARM: optprobes: execute instruction during restoring if possible Wang Nan
2015-01-07 13:40 ` [PATCH v19 00/11] ARM: kprobes: OPTPROBES and other improvements Jon Medhurst (Tixy)
2015-01-20 2:17 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AF7A79.20500@huawei.com \
--to=wangnan0@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).