* [PATCH] clocksource: sirf: Remove unused variable
@ 2014-12-15 15:59 Thierry Reding
2014-12-15 16:17 ` Daniel Lezcano
0 siblings, 1 reply; 10+ messages in thread
From: Thierry Reding @ 2014-12-15 15:59 UTC (permalink / raw)
To: linux-arm-kernel
From: Thierry Reding <treding@nvidia.com>
Commit ef89af1f4380 ("clocksource: sirf: Remove hard-coded clock rate")
removes all uses of the timer_div variable. Since the variable is no
longer used it should be removed.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/clocksource/timer-marco.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clocksource/timer-marco.c b/drivers/clocksource/timer-marco.c
index 361a789d4bee..3ddb81f7ee66 100644
--- a/drivers/clocksource/timer-marco.c
+++ b/drivers/clocksource/timer-marco.c
@@ -257,7 +257,6 @@ static void __init sirfsoc_clockevent_init(void)
/* initialize the kernel jiffy timer source */
static void __init sirfsoc_marco_timer_init(struct device_node *np)
{
- u32 timer_div;
struct clk *clk;
clk = of_clk_get(np, 0);
--
2.1.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] clocksource: sirf: remove unused variable
@ 2015-01-13 14:22 Arnd Bergmann
2015-01-13 14:27 ` Daniel Lezcano
0 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2015-01-13 14:22 UTC (permalink / raw)
To: linux-arm-kernel
A recent rework of the driver left an obviously unused variable
around, and now the compiler complains:
clocksource/timer-marco.c: In function 'sirfsoc_marco_timer_init':
clocksource/timer-marco.c:260:6: warning: unused variable 'timer_div' [-Wunused-variable]
Remove it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: ef89af1f4380b92 ("clocksource: sirf: Remove hard-coded clock rate")
diff --git a/drivers/clocksource/timer-marco.c b/drivers/clocksource/timer-marco.c
index 361a789d4bee..3ddb81f7ee66 100644
--- a/drivers/clocksource/timer-marco.c
+++ b/drivers/clocksource/timer-marco.c
@@ -257,7 +257,6 @@ static void __init sirfsoc_clockevent_init(void)
/* initialize the kernel jiffy timer source */
static void __init sirfsoc_marco_timer_init(struct device_node *np)
{
- u32 timer_div;
struct clk *clk;
clk = of_clk_get(np, 0);
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] clocksource: sirf: remove unused variable
2015-01-13 14:22 [PATCH] clocksource: sirf: remove " Arnd Bergmann
@ 2015-01-13 14:27 ` Daniel Lezcano
2015-01-13 15:24 ` Arnd Bergmann
2015-01-13 15:24 ` Barry Song
0 siblings, 2 replies; 10+ messages in thread
From: Daniel Lezcano @ 2015-01-13 14:27 UTC (permalink / raw)
To: linux-arm-kernel
On 01/13/2015 03:22 PM, Arnd Bergmann wrote:
> A recent rework of the driver left an obviously unused variable
> around, and now the compiler complains:
>
> clocksource/timer-marco.c: In function 'sirfsoc_marco_timer_init':
> clocksource/timer-marco.c:260:6: warning: unused variable 'timer_div' [-Wunused-variable]
>
> Remove it.
Hi Arnd,
thanks for the fix. But this has been already fixed and merged in my
tree [1].
-- Daniel
[1]
https://git.linaro.org/people/daniel.lezcano/linux.git/commitdiff/2a016d694f36fc31f7f9fede902346c5895702bb?hp=89de77a8c557f14d2713a1f43fbc33980e639b98
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: ef89af1f4380b92 ("clocksource: sirf: Remove hard-coded clock rate")
>
> diff --git a/drivers/clocksource/timer-marco.c b/drivers/clocksource/timer-marco.c
> index 361a789d4bee..3ddb81f7ee66 100644
> --- a/drivers/clocksource/timer-marco.c
> +++ b/drivers/clocksource/timer-marco.c
> @@ -257,7 +257,6 @@ static void __init sirfsoc_clockevent_init(void)
> /* initialize the kernel jiffy timer source */
> static void __init sirfsoc_marco_timer_init(struct device_node *np)
> {
> - u32 timer_div;
> struct clk *clk;
>
> clk = of_clk_get(np, 0);
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] clocksource: sirf: remove unused variable
2015-01-13 14:27 ` Daniel Lezcano
@ 2015-01-13 15:24 ` Arnd Bergmann
2015-01-13 15:39 ` Daniel Lezcano
2015-01-13 15:24 ` Barry Song
1 sibling, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2015-01-13 15:24 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 13 January 2015 15:27:05 Daniel Lezcano wrote:
> On 01/13/2015 03:22 PM, Arnd Bergmann wrote:
> > A recent rework of the driver left an obviously unused variable
> > around, and now the compiler complains:
> >
> > clocksource/timer-marco.c: In function 'sirfsoc_marco_timer_init':
> > clocksource/timer-marco.c:260:6: warning: unused variable 'timer_div' [-Wunused-variable]
> >
> > Remove it.
>
> Hi Arnd,
>
> thanks for the fix. But this has been already fixed and merged in my
> tree [1].
Ok, thanks. For some reason it has not shown up in Linux-next yet.
Is this branch supposed to be part of -next?
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] clocksource: sirf: remove unused variable
2015-01-13 14:27 ` Daniel Lezcano
2015-01-13 15:24 ` Arnd Bergmann
@ 2015-01-13 15:24 ` Barry Song
2015-01-13 16:22 ` Arnd Bergmann
1 sibling, 1 reply; 10+ messages in thread
From: Barry Song @ 2015-01-13 15:24 UTC (permalink / raw)
To: linux-arm-kernel
2015-01-13 22:27 GMT+08:00 Daniel Lezcano <daniel.lezcano@linaro.org>:
> On 01/13/2015 03:22 PM, Arnd Bergmann wrote:
>>
>> A recent rework of the driver left an obviously unused variable
>> around, and now the compiler complains:
>>
>> clocksource/timer-marco.c: In function 'sirfsoc_marco_timer_init':
>> clocksource/timer-marco.c:260:6: warning: unused variable 'timer_div'
>> [-Wunused-variable]
>>
>> Remove it.
>
>
> Hi Arnd,
>
> thanks for the fix. But this has been already fixed and merged in my tree
> [1].
>
> -- Daniel
>
> [1]
> https://git.linaro.org/people/daniel.lezcano/linux.git/commitdiff/2a016d694f36fc31f7f9fede902346c5895702bb?hp=89de77a8c557f14d2713a1f43fbc33980e639b98
>
yes, arnd. i also asked Daniel to apply "clocksource: marco: Rename
marco to atlas7" rebased on this fix here:
https://git.linaro.org/people/daniel.lezcano/linux.git/commit/81428bbe1d8a073bb3741678ef1d3c1016119c77
so this one is excluded from my pull request for atlas7. a
pull-request from arm-soc might cause merge conflicts?
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: ef89af1f4380b92 ("clocksource: sirf: Remove hard-coded clock rate")
-barry
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-13 16:22 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-15 15:59 [PATCH] clocksource: sirf: Remove unused variable Thierry Reding
2014-12-15 16:17 ` Daniel Lezcano
2015-01-11 15:58 ` Barry Song
2015-01-11 20:51 ` Daniel Lezcano
-- strict thread matches above, loose matches on Subject: below --
2015-01-13 14:22 [PATCH] clocksource: sirf: remove " Arnd Bergmann
2015-01-13 14:27 ` Daniel Lezcano
2015-01-13 15:24 ` Arnd Bergmann
2015-01-13 15:39 ` Daniel Lezcano
2015-01-13 15:24 ` Barry Song
2015-01-13 16:22 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).