From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ASoC: wm8904: fix runtime warning
Date: Tue, 13 Jan 2015 10:47:02 +0100 [thread overview]
Message-ID: <54B4E996.80403@metafoo.de> (raw)
In-Reply-To: <1421141643-30105-1-git-send-email-voice.shen@atmel.com>
On 01/13/2015 10:34 AM, Bo Shen wrote:
[...]
>
> - { "AIFOUTL", "Left", "ADCL" },
> - { "AIFOUTL", "Right", "ADCR" },
> - { "AIFOUTR", "Left", "ADCL" },
> - { "AIFOUTR", "Right", "ADCR" },
> + { "AIFOUTL Mux", "Left", "ADCL" },
> + { "AIFOUTL Mux", "Right", "ADCR" },
> + { "AIFOUTR Mux", "Left", "ADCL" },
> + { "AIFOUTR Mux", "Right", "ADCR" },
> +
> + { "AIFOUTL", NULL, "AIFOUTL Mux" },
> + { "AIFOUTR", NULL, "AIFOUTR Mux" },
>
This looks ok.
> { "ADCL", NULL, "CLK_DSP" },
> { "ADCL", NULL, "Left Capture PGA" },
> @@ -1089,14 +1092,20 @@ static const struct snd_soc_dapm_route adc_intercon[] = {
> };
>
> static const struct snd_soc_dapm_route dac_intercon[] = {
> - { "DACL", "Right", "AIFINR" },
> - { "DACL", "Left", "AIFINL" },
> + { "DACL", NULL, "AIFINL" },
> + { "DACL", NULL, "AIFINR" },
> { "DACL", NULL, "CLK_DSP" },
>
> - { "DACR", "Right", "AIFINR" },
> - { "DACR", "Left", "AIFINL" },
> + { "DACR", NULL, "AIFINL" },
> + { "DACR", NULL, "AIFINR" },
> { "DACR", NULL, "CLK_DSP" },
>
> + { "DACL Mux", "Left", "DACL" },
> + { "DACL Mux", "Right", "DACR" },
> +
> + { "DACR Mux", "Left", "DACL" },
> + { "DACR Mux", "Right", "DACR" },
> +
But this should probably be
> + { "DACL Mux", "Left", "AIFINL" },
> + { "DACL Mux", "Right", "AIFINR" },
> +
> + { "DACR Mux", "Left", "AIFINL" },
> + { "DACR Mux", "Right", "AIFINR" },
> +
> + { "DACL", NULL, "DACL Mux" },
> + { "DACR", NULL, "DACR Mux" },
prev parent reply other threads:[~2015-01-13 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 9:34 [PATCH v2] ASoC: wm8904: fix runtime warning Bo Shen
2015-01-13 9:47 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4E996.80403@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).