linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi
Date: Tue, 13 Jan 2015 13:32:41 +0100	[thread overview]
Message-ID: <54B51069.3000506@redhat.com> (raw)
In-Reply-To: <54B50B69.6000002@cogentembedded.com>

Hi,

On 13-01-15 13:11, Sergei Shtylyov wrote:
> Hello.
>
> On 1/13/2015 1:47 PM, Hans de Goede wrote:
>
>> The A23 has the same lradc controller as previous Allwinner SoCs.
>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   arch/arm/boot/dts/sun8i-a23.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/sun8i-a23.dtsi b/arch/arm/boot/dts/sun8i-a23.dtsi
>> index a31842d..c2ceafb 100644
>> --- a/arch/arm/boot/dts/sun8i-a23.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-a23.dtsi
>> @@ -419,6 +419,13 @@
>>               interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>>           };
>>
>> +        lradc: lradc at 01c22800 {
>> +            compatible = "allwinner,sun4i-a10-lradc-keys";
>
>     If this is a keyboard controller, its node name should probably be "keyboard", according to the ePAPR standard...

I'm not sure this qualifies as a keyboard controller, more over we
already have the same name in all other sun?i-a*.dtsi files, so if
we fix this it should be fixed by a follow up patch, and be fixed
everywhere.

Regards,

Hans

  reply	other threads:[~2015-01-13 12:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 10:47 [PATCH 1/2] ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi Hans de Goede
2015-01-13 10:47 ` [PATCH 2/2] ARM: dts: sun8i: Enable lradc on a23-ippo-q8h-v5 Hans de Goede
2015-01-13 12:11 ` [PATCH 1/2] ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi Sergei Shtylyov
2015-01-13 12:32   ` Hans de Goede [this message]
2015-01-13 16:47 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B51069.3000506@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).