From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch: arm: mach-davinci: cdce949.c: Remove unused function
Date: Wed, 14 Jan 2015 15:52:45 +0530 [thread overview]
Message-ID: <54B64375.3070406@ti.com> (raw)
In-Reply-To: <1417906928-5728-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Hi Rickard,
On Sunday 07 December 2014 04:32 AM, Rickard Strandqvist wrote:
> Remove the function cdce_set_rate() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/arm/mach-davinci/cdce949.c | 37 --------------------------
> arch/arm/mach-davinci/include/mach/cdce949.h | 2 --
> 2 files changed, 39 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/cdce949.c b/arch/arm/mach-davinci/cdce949.c
> index abafb92..bccac4a 100644
> --- a/arch/arm/mach-davinci/cdce949.c
> +++ b/arch/arm/mach-davinci/cdce949.c
> @@ -212,43 +212,6 @@ static struct cdce_output output_list[] = {
> [5] = { cdce_y5_freqs, ARRAY_SIZE(cdce_y5_freqs) },
> };
>
> -int cdce_set_rate(struct clk *clk, unsigned long rate)
Without this function, this driver is of no use. I can see that CDCE949
support has remained unused for long time. I would rather see the entire
support including cdce949.c and cdce949.h and their references removed.
Thanks,
Sekhar
next prev parent reply other threads:[~2015-01-14 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 23:02 [PATCH] arch: arm: mach-davinci: cdce949.c: Remove unused function Rickard Strandqvist
2015-01-14 10:22 ` Sekhar Nori [this message]
2015-01-14 22:56 ` Rickard Strandqvist
2015-01-16 15:47 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B64375.3070406@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).