linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arch: arm: mach-davinci: serial.c: Cleaning up function that are not used anywhere
@ 2014-12-02 22:08 Rickard Strandqvist
  2015-01-14 10:29 ` Sekhar Nori
  0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-12-02 22:08 UTC (permalink / raw)
  To: linux-arm-kernel

Remove function serial_read_reg() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 arch/arm/mach-davinci/serial.c |   10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm/mach-davinci/serial.c b/arch/arm/mach-davinci/serial.c
index 5e93a73..951b620 100644
--- a/arch/arm/mach-davinci/serial.c
+++ b/arch/arm/mach-davinci/serial.c
@@ -31,16 +31,6 @@
 #include <mach/serial.h>
 #include <mach/cputype.h>
 
-static inline unsigned int serial_read_reg(struct plat_serial8250_port *up,
-					   int offset)
-{
-	offset <<= up->regshift;
-
-	WARN_ONCE(!up->membase, "unmapped read: uart[%d]\n", offset);
-
-	return (unsigned int)__raw_readl(up->membase + offset);
-}
-
 static inline void serial_write_reg(struct plat_serial8250_port *p, int offset,
 				    int value)
 {
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] arch: arm: mach-davinci: serial.c: Cleaning up function that are not used anywhere
  2014-12-02 22:08 [PATCH] arch: arm: mach-davinci: serial.c: Cleaning up function that are not used anywhere Rickard Strandqvist
@ 2015-01-14 10:29 ` Sekhar Nori
  0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2015-01-14 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday 03 December 2014 03:38 AM, Rickard Strandqvist wrote:
> Remove function serial_read_reg() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Queuing for v3.20 with subject updated to:

"ARM: davinci: serial.c: remove unused serial_read_reg()"

Thanks,
Sekhar

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-14 10:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-02 22:08 [PATCH] arch: arm: mach-davinci: serial.c: Cleaning up function that are not used anywhere Rickard Strandqvist
2015-01-14 10:29 ` Sekhar Nori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).